Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set launch_template.ami_id attrs to private #2842

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Set launch_template.ami_id attrs to private #2842

merged 4 commits into from
Nov 13, 2024

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Nov 11, 2024

This PR will disable the configuration of node_groups.*.launch_template.ami_id specifically, until #2832 is addressed.

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@viniciusdc viniciusdc marked this pull request as draft November 11, 2024 15:42
@viniciusdc
Copy link
Contributor Author

viniciusdc commented Nov 11, 2024

Checking pydantic docs to be sure this is the correct setting https://docs.pydantic.dev/1.10/usage/models/#private-model-attributes

@viniciusdc viniciusdc marked this pull request as ready for review November 12, 2024 15:49
@viniciusdc
Copy link
Contributor Author

This is what the validation error will look like if the user tries to pass the ami_id field
image

The reason for not completely removing it, is that once the error on the terraform side of things is addressed, we can just re-enable this field instead of re-including

@viniciusdc
Copy link
Contributor Author

just waiting for the tests

@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Nov 13, 2024
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dcmcand dcmcand merged commit 87ed92b into main Nov 13, 2024
26 checks passed
@dcmcand dcmcand deleted the disable-ami-id branch November 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants