Allow overriding of keycloak root credentials for 2024.11.1 upgrade path
#2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdc
commented
Nov 11, 2024
|
needs to be validated if the keycloak_admin.get_server_info works as a first layer credential check |
src/_nebari/upgrade.py
Outdated
| exit() | ||
| else: | ||
| # Handle other exceptions | ||
| print(f"[red bold]An unexpected error occurred: {e}[/red bold]") |
There was a problem hiding this comment.
Will the whole stack trace be in red bold?
There was a problem hiding this comment.
I see it doesn't print out the stack trace. I agree with the comments on https://stackoverflow.com/a/1483488/9848141 that repr would be better than str(e) to give more info about what is happening.
src/_nebari/upgrade.py
Outdated
| if "invalid_grant" in str(e): | ||
| print( | ||
| "[red bold]Failed to connect to the Keycloak server.[/red bold]\n" | ||
| "[yellow]This may occur if the default admin credentials have been changed for security reasons.[/yellow]\n" |
There was a problem hiding this comment.
I feel like this makes it sound like the user did something wrong or optional when in reality changing the security credentials should be the default behaviors. I'll suggest an edit.
Co-authored-by: Adam Lewis <23342526+Adam-D-Lewis@users.noreply.github.com>
|
This is how it looks like now: |
Adam-D-Lewis
approved these changes
Nov 12, 2024
viniciusdc
added a commit
that referenced
this pull request
Nov 13, 2024
… path (#2843) Co-authored-by: Adam Lewis <23342526+Adam-D-Lewis@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
closes #2833
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
Any other comments?