Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug to allow --import-plugin to work #2864

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Nov 27, 2024

Reference Issues or PRs

nebari --import-plugin path/to/plugin.py <command> ...
nebari --import-plugin import.module.plugin.path <command> ...

as explained in the instructions in https://www.nebari.dev/docs/how-tos/nebari-extension-system#installing-a-plugin don't work currently. This fixes that error.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  • Clone git@github.com:Quansight/nebari-mlflow-plugin.git locally
  • run nebari init -p 'myproject' on main branch of nebari repo
  • add the following to the nebari config file
mlflow:
  enabled: false
  • run nebari --import-plugin <your-path-to-repo>/nebari-mlflow-plugin/src/nebari_mlflow_plugin/__init__.py deploy -c nebari-config.yaml. You'll get an error saying extra config in MLflow is not supported.
  • Do the same thing but on this branch and deployment will start.

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis! Just tested this and works as expected 🚀

@Adam-D-Lewis Adam-D-Lewis merged commit 6eb248f into main Dec 29, 2024
27 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the fix-import-plugin-cli-option branch December 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants