Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gcp instance validation #2875

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Dec 9, 2024

Reference Issues or PRs

gcp provider tests are failing because the wrong google cloud client was used.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

CI passes

Any other comments?

@dcmcand dcmcand added this to the 2024.12.1 release milestone Dec 9, 2024
instances_client = compute_v1.MachineTypesClient(credentials=credentials)
zone_list = zones_client.list(project=project_id, region=region)
zones = [zone for zone in zone_list]
instance_set: set[str] = set()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to use type hints here but nowhere else in the variable definitions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because mypy wanted me to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I did not realize we were using mypy. I don't have a problem with using type hints but it's the first time I see we are using them within variable definitions

@dcmcand dcmcand merged commit 7acea49 into main Dec 9, 2024
26 checks passed
@dcmcand dcmcand deleted the update-gcp-instance-validation branch December 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants