-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement : Moved Docker images repo to docker folder in main branch #2932
base: main
Are you sure you want to change the base?
Conversation
Hey @Helion55 thanks for opening this PR! we will have a look during the following days, in nebari we use pre-commit to lint the files and commit changes; its just a few typos, but if you want then to be self-fixed, you can
|
Hey, @ Helion55, I am giving you a heads-up on the review status. We are finishing the latest release of Nebari. Once that's out,, we will include this PR on our discussion board next week. Once again, thanks for opening the PR! |
Thanks @viniciusdc, I was curious about it. I have fixed the thing that you had mentioned. Waiting to catch up on next week. |
@@ -0,0 +1,41 @@ | |||
# Copyright (c) Nebari Development Team. |
Check failure
Code scanning / Trivy
Image user should not be 'root' High
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@@ -0,0 +1,41 @@ | |||
# Copyright (c) Nebari Development Team. |
Check notice
Code scanning / Trivy
No HEALTHCHECK defined Low
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
@@ -0,0 +1,41 @@ | |||
# Copyright (c) Nebari Development Team. |
Check failure
Code scanning / Trivy
Image user should not be 'root' High
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@@ -0,0 +1,41 @@ | |||
# Copyright (c) Nebari Development Team. |
Check notice
Code scanning / Trivy
No HEALTHCHECK defined Low
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
@@ -0,0 +1,70 @@ | |||
# Copyright (c) Nebari Development Team. |
Check failure
Code scanning / Trivy
Image user should not be 'root' High
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@@ -0,0 +1,70 @@ | |||
# Copyright (c) Nebari Development Team. |
Check notice
Code scanning / Trivy
No HEALTHCHECK defined Low
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
@@ -0,0 +1,61 @@ | |||
# Copyright (c) Nebari Development Team. |
Check failure
Code scanning / Trivy
Image user should not be 'root' High
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@@ -0,0 +1,61 @@ | |||
# Copyright (c) Nebari Development Team. |
Check notice
Code scanning / Trivy
No HEALTHCHECK defined Low
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
Reference Issues or PRs
Fixes #2871
What does this implement/fix?
Moved docker-images repo back to main nebari's repo. Changes made,
docker
and moved the necessary files from docker repository..github/workflows
folder by adding thebuild-push-docker.yaml
andtest-images.yaml
files from docker repo's workflow folder.documentation.yml
andRFD.md
files to.github/ISSUE_TEMPLATE
folder..pre-commit-config.yaml
file.Testing
no
no
Any other comments?
no