Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating ssl certs via DNS challenge (via Cloudflare) #2957

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/_nebari/stages/kubernetes_ingress/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import enum
import logging
import os
import socket
import sys
import time
Expand Down Expand Up @@ -124,13 +125,19 @@ def to_yaml(cls, representer, node):
return representer.represent_str(node.value)


class AcmeChallengeType(str, enum.Enum):
tls = "tls"
dns = "dns"


class Certificate(schema.Base):
type: CertificateEnum = CertificateEnum.selfsigned
# existing
secret_name: Optional[str] = None
# lets-encrypt
acme_email: Optional[str] = None
acme_server: str = "https://acme-v02.api.letsencrypt.org/directory"
acme_challenge_type: Optional[str] = AcmeChallengeType.tls.value


class DnsProvider(schema.Base):
Expand Down Expand Up @@ -183,7 +190,19 @@ def input_vars(self, stage_outputs: Dict[str, Dict[str, Any]]):
cert_details["certificate-secret-name"] = (
self.config.certificate.secret_name
)

cert_details["acme-challenge-type"] = (
self.config.certificate.acme_challenge_type
)
if self.config.certificate.acme_challenge_type == AcmeChallengeType.dns.value:
if os.environ.get("CLOUDFLARE_TOKEN") is None:
raise ValueError(
"Environment variable 'CLOUDFLARE_TOKEN' must be set along with "
"'DNS:Edit' permission for DNS challenge type ('acme_challenge_type: dns')"
)
else:
cert_details["cloudflare-dns-api-token"] = os.environ.get(
"CLOUDFLARE_TOKEN"
)
return {
**{
"traefik-image": {
Expand Down
2 changes: 2 additions & 0 deletions src/_nebari/stages/kubernetes_ingress/template/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ module "kubernetes-ingress" {
certificate-service = var.certificate-service
acme-email = var.acme-email
acme-server = var.acme-server
acme-challenge-type = var.acme-challenge-type
cloudflare-dns-api-token = var.cloudflare-dns-api-token
certificate-secret-name = var.certificate-secret-name
load-balancer-annotations = var.load-balancer-annotations
load-balancer-ip = var.load-balancer-ip
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,33 @@ locals {
"--entrypoints.websecure.http.tls.certResolver=default",
"--entrypoints.minio.http.tls.certResolver=default",
]
certificate-challenge = {
dns = [
"--certificatesresolvers.letsencrypt.acme.dnschallenge=true",
# Only cloudflare is supported at the moment for DNS challenge
# TODO: add support for other DNS providers
"--certificatesresolvers.letsencrypt.acme.dnschallenge.provider=cloudflare"
]
tls = [
"--certificatesresolvers.letsencrypt.acme.tlschallenge",
]
}
# for dns challenge, we need to set the cloudflare env vars
cloudflare_env_vars = var.acme-challenge-type == "dns" ? [
{
name = "CLOUDFLARE_DNS_API_TOKEN"
value = var.cloudflare-dns-api-token
}
] : []
certificate-settings = {
lets-encrypt = [
lets-encrypt = concat([
"--entrypoints.websecure.http.tls.certResolver=letsencrypt",
"--entrypoints.minio.http.tls.certResolver=letsencrypt",
"--certificatesresolvers.letsencrypt.acme.tlschallenge",
"--certificatesresolvers.letsencrypt.acme.email=${var.acme-email}",
"--certificatesresolvers.letsencrypt.acme.storage=/mnt/acme-certificates/acme.json",
"--certificatesresolvers.letsencrypt.acme.caserver=${var.acme-server}",
]
], local.certificate-challenge[var.acme-challenge-type]
)
self-signed = local.default_cert
existing = local.default_cert
disabled = []
Expand Down Expand Up @@ -231,6 +249,14 @@ resource "kubernetes_deployment" "main" {
image = "${var.traefik-image.image}:${var.traefik-image.tag}"
name = var.name

dynamic "env" {
for_each = local.cloudflare_env_vars
content {
name = env.value.name
value = env.value.value
}
}

volume_mount {
mount_path = "/mnt/acme-certificates"
name = "acme-certificates"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,23 @@ variable "acme-server" {
default = "https://acme-staging-v02.api.letsencrypt.org/directory"
}

variable "acme-challenge-type" {
# https://letsencrypt.org/docs/challenge-types
description = "ACME challenge type, 'tls' or 'dns'"
default = "tls"
}

variable "cloudflare-dns-api-token" {
# https://go-acme.github.io/lego/dns/cloudflare/
description = "Cloudflare dns api token for DNS challenge"
default = null
}

variable "acme-dns-provider" {
description = "ACME DNS provider"
default = "route53"
}

variable "certificate-secret-name" {
description = "Kubernetes secret used for certificate"
type = string
Expand Down
12 changes: 12 additions & 0 deletions src/_nebari/stages/kubernetes_ingress/template/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@ variable "acme-server" {
default = "https://acme-staging-v02.api.letsencrypt.org/directory"
}

variable "acme-challenge-type" {
# https://letsencrypt.org/docs/challenge-types
description = "ACME challenge type, 'tls' or 'dns'"
default = "tls"
}

variable "cloudflare-dns-api-token" {
# https://go-acme.github.io/lego/dns/cloudflare/
description = "Cloudflare dns api token for DNS challenge"
default = null
}

variable "certificate-secret-name" {
description = "Kubernetes secret used for certificate"
default = ""
Expand Down
6 changes: 6 additions & 0 deletions tests/tests_unit/cli_validate/min.happy.certificate.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
project_name: test
certificate:
type: lets-encrypt
acme_email: admin@quansight.com
acme_server: https://acme-v02.api.letsencrypt.org/directory
acme_challenge_type: dns
Loading