Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce minimum nodes in user and dask node pools to 0 for Azure / GCP #723

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

tarundmsharma
Copy link
Contributor

Revert changes: Update min_nodes for some cloud providers #709

revertchanges-for-#709
@viniciusdc
Copy link
Contributor

viniciusdc commented Aug 4, 2021

@costrouc Could you have a look at this too? As you've commented about some special circumstances for the cloud providers... Those changes should revert the min nodes configuration to the original structure (before 0.3.12 release, see #709 )

@tonyfast tonyfast requested a review from costrouc November 15, 2021 19:10
@tonyfast
Copy link
Contributor

@costrouc i added you as a reviewer to this. @viniciusdc has already approved, what do you think we should do?

@iameskild
Copy link
Member

Reading through the Azure AKS node pool docs, it appears that the minimum number of nodes in a user pool can be set to 0.

See the third bullet point under limitations:

System pools must contain at least one node, and user node pools may contain zero or more nodes.

@iameskild iameskild changed the title Update initialize.py Reduce minimum nodes in user and dask node pools to 0 Nov 17, 2021
@iameskild iameskild changed the title Reduce minimum nodes in user and dask node pools to 0 Reduce minimum nodes in user and dask node pools to 0 for Azure deployments Nov 17, 2021
@iameskild iameskild changed the title Reduce minimum nodes in user and dask node pools to 0 for Azure deployments Reduce minimum nodes in user and dask node pools to 0 for Azure / GCP Nov 18, 2021
@iameskild
Copy link
Member

Reading the docs for the GCP node pool and auto-scaler, it also appears that we can scale user / dask node pools to 0.

See GKE auto-scaler minimum and maximum node pools:

Note: If you specify a minimum of zero nodes, an idle node pool can scale down completely. However, at least one node must always be available in the cluster to run system Pods.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docs it seems that azure and gcp both support scaling down to zero. Thanks!

@costrouc costrouc merged commit 90e3448 into main Nov 19, 2021
@costrouc costrouc deleted the tarundmsharma-patch-1-revertchanges-for-#709 branch November 19, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants