-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding name convention validator for QHub project name #761
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e28d83b
add validation to project name
viniciusdc 6497cf7
Add project naming convention validator
viniciusdc 911eef3
backen
viniciusdc 17886c2
Commit suggestions
viniciusdc 5547781
Commit suggestions
viniciusdc c0848c4
Commit suggestions
viniciusdc 73fb5e1
Commit suggestions
viniciusdc a0f11c2
Commit suggestions
viniciusdc 0ce8634
update regex
viniciusdc 6d1c489
Add loop for azure provider project name check
tarundmsharma 8dcca0f
Adding project name check for azure deployment
tarundmsharma 6e71f46
Formatting code using black
tarundmsharma 7cc5b21
adding naming convection check for azure
tarundmsharma 398d31c
black formatting
tarundmsharma e2268f9
adding naming convection check for azure only
tarundmsharma 26e1abc
adding naming convection check for azure only
tarundmsharma af8323c
Validator for Azure only
tarundmsharma 087c46d
changes in project name for test files
tarundmsharma 737565a
changes in project name for test files
tarundmsharma 53caea9
Project name validator
tarundmsharma 828c71a
black formatting
tarundmsharma 6f21ec9
flake8 error
tarundmsharma 74b7c62
Check for provider and raise related message
viniciusdc 4414266
Undo changes into test project names
viniciusdc 47c522d
Merge branch 'main' into project_name_regex
iameskild 43b7305
Merge branch 'main' into project_name_regex
5d97dc7
Fix project name to please validator
ce849f7
Merge branch 'main' into project_name_regex
viniciusdc f4ceca9
Merge remote-tracking branch 'origin/main' into project_name_regex
viniciusdc 7ac47fb
Blacken
viniciusdc aea17c5
Merge branch 'main' into project_name_regex
costrouc 00caa91
Update project name
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this come from? It looks like the current aws test has a project name
aws-test
This is causing the AWS tests to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the description... but I don't remember why we need to avoid that. I remember a discussion about that a really long time ago... Anyways I will need to add another step in that validation because the Azure storage name must not contain any dashes