add prefectLabels and envVars to prefect config #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
commented
Aug 19, 2021
| @@ -40,7 +40,7 @@ spec: | |||
| - name: IMAGE_PULL_SECRETS | |||
| value: '' | |||
| - name: PREFECT__CLOUD__AGENT__LABELS | |||
| value: '[]' | |||
| value: {{ .Values.agent.prefectLabels | toJson | quote }} | |||
There was a problem hiding this comment.
jhamman
commented
Aug 19, 2021
| @@ -57,6 +57,8 @@ spec: | |||
| value: cloud | |||
| - name: PREFECT__CLOUD__AGENT__AGENT_ADDRESS | |||
| value: http://:8080 | |||
| - name: PREFECT__CLOUD__AGENT__ENV_VARS | |||
| value: {{ .Values.agent.envVars | toJson | quote }} | |||
There was a problem hiding this comment.
Prefect's server doesn't include this variable but the agent cli does:
prefect agent kubernetes install -e "spam=more"
...
- name: PREFECT__CLOUD__AGENT__ENV_VARS
value: '{"spam": "more"}'
...
costrouc
reviewed
Aug 19, 2021
| @@ -235,6 +235,12 @@ module "prefect" { | |||
| {% if cookiecutter.prefect.image is defined -%} | |||
| image = "{{ cookiecutter.prefect.image }}" | |||
| {% endif -%} | |||
| {% if cookiecutter.prefect.agent.prefectLabels is defined -%} | |||
| image = "{{ cookiecutter.prefect.agent.prefectLabels }}" | |||
There was a problem hiding this comment.
Think this will need to be changed to
agent = {
{% if cookiecutter.prefect.agent.prefectLabels is defined -%}
prefectLabels = "{{ cookiecutter.prefect.agent.prefectLabels }}"
{% endif %}
...
}
|
Thanks for the PR @jhamman! I personally was not that responsible for the prefect agent deployment but I will make sure to check out this PR in more detail tomorrow. |
|
Fantastic! Thanks @Adam-D-Lewis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick attempt at adding labels and environment variables to the prefect agent chart. This is my first time touching qhub and terraform so I'm very open to suggestions on better ways to go about this.
If you are starting a review, I'd start at
.../services/prefect/chart/templates/prefect.yamland work backwards from there.This initial implementation would expose two new parameters under
prefectlike this:closes #764