-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Traefik Dashboard #797
Merged
Merged
Changes from 48 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
f48f364
add grafana traefik route
balast 8144ee0
grafana working
balast 6677c3e
prometheus-helm-chart-working
balast 62b6be4
initial integration - wip
balast f200ab3
add external-url variable
balast 1529ca9
add external-url variable
balast 29e83a1
add tls var
balast 43fbbc4
add tls var
balast d1d21bc
add tls var
balast dc23e26
merge with main
balast 06c7cac
cluster monitoring docs
balast ddb28e9
fix debug change
balast 6e9e4d4
fix formatting, delete ingress
balast b9b0eb5
add monitoring by default, fix routing service name
balast 169766d
terraform format
balast f23e99d
Update monitoring instructions
Adam-D-Lewis c32074d
don't include helm chart in repo
balast 9da48ee
Merge branch 'prometheus_grafana' of github.com:Quansight/qhub into p…
balast 47be777
terraform format
balast a851719
terraform format
balast d08db3f
add the values file back
balast 689ca2a
remove values files
6d25c36
terraform fmt
f30c0bf
terraform fmt
5130237
Merge branch 'main' into prometheus_grafana
59b0ef0
Merge remote-tracking branch 'origin/main' into prometheus_grafana
1bf1d19
up minikube memory
120321e
set CI minikube memory to 6500mb
6300040
move kubernetes tests to new file
844aa52
use self-hosted action runner (cirun.io)
7cb1247
add .cirun.yml
063ce2a
Misc fixes
aktech 439ea44
Install cypress after k8s tests
aktech 4b8ad35
use cheapest acceptable DO droplet
5d0e799
add release notes
33f3440
configure traefik to output metrics to prometheus
83e3f53
commented out lines for later
2cb8ff2
deleted commented out lines
f7074a3
Merge branch 'main' into prometheus_grafana
24f3b06
enable prometheus monitoring of traefik
bda0631
add some labels to automatically add traefik dashboards
9c23ab0
remove unneccessary comment
d0a7db2
reformat comment
702b252
apply terraform fmt
b876b03
apply terraform fmt
6a031d6
working example of loading dashboard
59b27b0
add traefik dashboard
deb462a
remove namespace from most graphs
b30a54a
remove label requirement for scraping
5662e19
fix namespace selector in dashboard
84ba2a9
trigger CICD
e204896
fix render error
a02265b
fix
02d55dd
Combine traefik return codes into a single graph
tylerpotts b5f41ef
test change to kubernetes tests
d2eeedf
Merge branch 'prometheus_grafana' of github.com:Quansight/qhub into p…
1851697
add wait for cyprus run
1e0e6ed
Revert "add wait for cyprus run"
07ea7f9
Merge branch 'main' into prometheus_grafana
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...ecutter.repo_directory }}/infrastructure/modules/kubernetes/services/monitoring/locals.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
locals { | ||
traefik_dashboard = file("${path.module}/traefik.json") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As set up now, this will scrape only k8s services with both labels
app.kubernetes.io/component: traefik-internal-service
andprometheus.io/scrape: true
(see relabel configs).It is possible to instead scrape all services with the label
prometheus.io/scrape: true
, but they'll all be included under the same prometheus job. I'm not sure if that's the "right way" to do things in Prometheus given their definition of job which I've pasted below (from here):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@costrouc, your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this since for each new service we'll have to add a new job for scraping.
This is exactly what I'd like to have. I'd like to not have to require development to qhub to require additional modifications to the monitoring configuration.