Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qhub Extension #886

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Qhub Extension #886

merged 8 commits into from
Nov 5, 2021

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Oct 27, 2021

Adds the ability to specify arbitrary helm charts in the qhub config.

There may be some collisions between this PR and the keycloak PR that still need to be resolved. Also, docs still need to be added.

@Adam-D-Lewis Adam-D-Lewis requested a review from costrouc October 27, 2021 23:18
@Adam-D-Lewis Adam-D-Lewis changed the title Qhub extension [WIP] Qhub extension Oct 27, 2021
@Adam-D-Lewis
Copy link
Member Author

@costrouc Ready for review!

@Adam-D-Lewis Adam-D-Lewis changed the title Qhub extension Qhub Extension (Ready for Review) Oct 27, 2021
qhub/schema.py Show resolved Hide resolved
@Adam-D-Lewis Adam-D-Lewis requested a review from aktech October 29, 2021 13:45
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Adam-D-Lewis Adam-D-Lewis merged commit 6008711 into main Nov 5, 2021
@aktech aktech deleted the qhub-extension branch November 5, 2021 13:46
@Adam-D-Lewis Adam-D-Lewis changed the title Qhub Extension (Ready for Review) Qhub Extension Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants