Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete existing .gitlab-ci.yml when rendering #887

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Delete existing .gitlab-ci.yml when rendering #887

merged 3 commits into from
Nov 3, 2021

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Oct 28, 2021 •
edited
Loading

Issue detected by @viniciusdc when working with a client that uses GitLab.

To do:

  • Add test for gitlab deployments

@viniciusdc
Copy link
Contributor

@iameskild which kind of test are you expecting?

@iameskild
Copy link
Member Author

@viniciusdc sorry I should've specified that I want to add a test for gitlab deployments (initial comment updated). In my PR #874, I made some changes to the test suite that I think will make it easier for us to add tests. I haven't done so yet, but I will make sure that we also test gitlab deployments as part of that PR.

@viniciusdc
Copy link
Contributor

@viniciusdc sorry I should've specified that I want to add a test for gitlab deployments (initial comment updated). In my PR #874, I made some changes to the test suite that I think will make it easier for us to add tests. I haven't done so yet, but I will make sure that we also test gitlab deployments as part of that PR.

Could we add the tests within that PR then? I would like to merge this ASAP if possible

@iameskild
Copy link
Member Author

@viniciusdc, feel free to merge this whenever you'd like. I will add some gitlab tests to other PR by the end of the week.

viniciusdc
viniciusdc approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iameskild iameskild merged commit 38faf90 into main Nov 3, 2021
@iameskild iameskild deleted the gh767_ee_fix branch November 3, 2021 16:33
viniciusdc pushed a commit that referenced this pull request Nov 9, 2021
@iameskild @viniciusdc
xDelete existing .gitlab-ci.yml when rendering (#887)
a303971 
* Add unlink for files

* Set verbosity to 0
viniciusdc pushed a commit that referenced this pull request Nov 11, 2021
@iameskild @viniciusdc
Delete existing .gitlab-ci.yml when rendering (#887)
20f9793 
* Add unlink for files

* Set verbosity to 0
leej3 pushed a commit that referenced this pull request Nov 16, 2021
@iameskild @leej3
Delete existing .gitlab-ci.yml when rendering (#887)
114c943 
* Add unlink for files

* Set verbosity to 0
leej3 pushed a commit that referenced this pull request Nov 17, 2021
@iameskild @leej3
Delete existing .gitlab-ci.yml when rendering (#887)
0490280 
* Add unlink for files

* Set verbosity to 0
tylerpotts pushed a commit that referenced this pull request Nov 19, 2021
@iameskild @tylerpotts
Delete existing .gitlab-ci.yml when rendering (#887)
dfc9722 
* Add unlink for files

* Set verbosity to 0
@tylerpotts tylerpotts mentioned this pull request Nov 19, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iameskild @viniciusdc