Pin terraform providers #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2021 09:46
aktech
reviewed
Nov 11, 2021
| @@ -12,10 +13,12 @@ terraform { | |||
| {%- elif cookiecutter.provider == "gcp" %} | |||
| google = { | |||
| source = "hashicorp/google" | |||
| version = "=3.89.0" | |||
There was a problem hiding this comment.
is the = intentional here? (same for digitalocean as well)
There was a problem hiding this comment.
Yeah, just a style preference. Without the = sign works too. https://www.terraform.io/docs/language/expressions/version-constraints.html
costrouc
approved these changes
Nov 12, 2021
costrouc
approved these changes
Nov 12, 2021
tylerpotts
pushed a commit
that referenced
this pull request
Nov 19, 2021
* pin google * pin all terraform cloud providers Co-authored-by: Adam-D-Lewis <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
Further comments (optional)
I would say best way to test is with the auto deploy tests of qhub.