Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup/Add integration/deployment tests via pytest #922

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Nov 15, 2021

Changes:

Sets up a simple framework for writing integration/deployment tests for the deployed QHub on minikube.
Currently added basic tests for Dask Gateway.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Added tests for running via pytest.

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

Copy link
Contributor

@danlester danlester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I still think it would be worthwhile adding a Dask-based Jupyter notebook to be run during the Cypress stage :) But maybe another time...

Apart from my notes about dev environment packages, the pytests run OK for me.


# deployment/integration tests dependencies
- dask-gateway
- python-kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be kubernetes not python-kubernetes (which is very old, and doesn't work with the tests).

But also, note that pip install -e .[dev] does not make use of this environment-dev.yaml file, so really "kubernetes" and "dask-gateway" need to be added to the dev list in setup.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct pip package is kubernetes, but the conda's kubernetes package didn't work for me yesterday and python-kubernetes seems to work, either ways I'll update the dev dependency.

Copy link
Contributor

@danlester danlester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I wasn't thinking about Conda. Either way, the new setup.py looks better for pip.

@aktech aktech merged commit f555bce into main Nov 16, 2021
@aktech aktech deleted the deployment-pytests branch November 16, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants