Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-initialization depends_on kubernetes #952

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

danlester
Copy link
Contributor

In AWS integration tests, sometimes we see namespace is trying to be created before cluster is fully up.

Terraform should maybe spot this dependency anyway since provider needs to use outputs but maybe this will help.

Changes:

  • kubernetes-initialization depends_on kubernetes

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@danlester danlester merged commit c8853ad into main Dec 1, 2021
@danlester danlester deleted the dependson branch December 1, 2021 12:20
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @danlester

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants