No Users group by default #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed accidentally |
|
HI Dan, thanks for the PR. I will test it! 👍 |
|
Hi @danlester, sorry for the late feedback on this. I totally agree of the user group removal, but I didn't understand the optional user/shared settings... how that will interact with the recent changes proposed in #1003 |
|
Yes, it's possible this is all outdated now. Let's see once the other PR is merged. |
costrouc
added a commit
that referenced
this pull request
Feb 11, 2022
Closes #957 This adds an option for `security.shared_users_group` which is by default False. If True all users created after this option is set True will be added to the `users` group. If any users were created before this option they must manually be added to this group.
This was referenced Feb 11, 2022
danlester
added a commit
that referenced
this pull request
Feb 12, 2022
) * Adding security.shared_users_group option for default users group Closes #957 This adds an option for `security.shared_users_group` which is by default False. If True all users created after this option is set True will be added to the `users` group. If any users were created before this option they must manually be added to this group. * shared_users_group added on 0.4.0 upgrade; docs for users Co-authored-by: Dan Lester <dan@ideonate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921
Changes:
usersdefault group any more.security.shared_users_groupfield inqhub-config.yaml- if true, theusersdefault group will be created. This will mean there is a shared folder for everyone to use.--shared-users-groupflag toqhub initwhich will addsecurity.shared_users_group: trueto theqhub-config.yamlfile. If the flag is omitted, the user will be asked if they want thisusersgroup or not (unless--disable-promptpassed, in which case shared_users_group defaults to false.sharedfolder if there are any shared folder mounts available to the JupyterLab session.qhub upgradefrom earlier versions will addsecurity.shared_users_group: trueif there was ausersgroup specified in the incomingqhub-config.yamlfile.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?