Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyterhub-idle-culler to jupyterhub image #959

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

danlester
Copy link
Contributor

@danlester danlester commented Dec 6, 2021

Fixes #958
Fixes #960
Fixes #961

Changes:

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

Starting this branch should build the image then I will test it.

@danlester danlester self-assigned this Dec 6, 2021
@danlester danlester requested a review from tylerpotts December 7, 2021 11:17
@danlester danlester added this to the Release v0.4.0 milestone Dec 7, 2021
Copy link
Contributor

@tylerpotts tylerpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danlester danlester merged commit 4c2b588 into main Dec 8, 2021
@iameskild iameskild deleted the idleculler branch May 11, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants