Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge hub.extraEnv env vars and hub.extraConfig in jupyterhub helm chart.
Changes:
If the following is in the qhub-config.yaml file:
then, despite the overrides supposed to be added to the JupyterHub Helm release, previously anything under
hub.extraEnv
would be lost when further overridden by QHub's own required env vars.This PR merges them instead so the user's env vars should make it into the Hub pod.
Similarly for extraConfig.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?