FEAT: Add additional port to handle Minio object storage #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdc
added
area: integration/conda-store
area: terraform 💾
needs: review 👀
viniciusdc
approved these changes
Jan 18, 2022
costrouc
approved these changes
Jan 18, 2022
costrouc
approved these changes
Jan 18, 2022
costrouc
added a commit
that referenced
this pull request
Jan 18, 2022
* Adding support for nix flakes * Adding dependencies * Adding .direnv * Adding conda-store terraform charts along with postgres/minio charts * Adding changes to ensure postgresql and minio deployment * Make easy connection to s3 and database storage * Adding url for conda-store in qhub * Adding documentation on Conda-Store environment management * Fixing all refrences to old conda-store image * Remove use of fstring flake8 formatting * FEAT: Add additional port to handle Minio object storage (#988) * FEAT: Add additional port to handle Minio object storage * Add missing vars * Update minio entrypoint and disable tls * Exclude traitlets config from pre-commit * Update conda-store minio service eternal endpoint Co-authored-by: viniciusdc <vinivdc2009@hotmail.com> Co-authored-by: Harsh Mishra <erbeusgriffincasper@gmail.com> Co-authored-by: viniciusdc <vinivdc2009@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #980
Changes:
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Testing locally and on GCP.