Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add insertEdgeBatch function #234 #244

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

shbone
Copy link
Contributor

@shbone shbone commented Oct 10, 2023

According to #234 (comment) #234
add insertEdgeBatch function
include:

  • test module
  • reformat src/main/resources/NebulaDaoBasic.xml
    cc @CorvusYe Thank you!

@wey-gu wey-gu requested a review from CorvusYe October 10, 2023 05:21
Copy link
Collaborator

@CorvusYe CorvusYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to move NgTriplet to the models of the main project, which is at the same level as NgPath.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (fbeb601) 0.00% compared to head (b27d4e2) 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #244   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          74      75    +1     
  Lines        2532    2562   +30     
  Branches      275     276    +1     
======================================
- Misses       2532    2562   +30     
Files Coverage Δ
...g/nebula/contrib/ngbatis/proxy/NebulaDaoBasic.java 0.00% <0.00%> (ø)
.../nebula/contrib/ngbatis/models/data/NgTriplet.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shbone shbone changed the title Feat: add insertEdgeBatch function Feat: add insertEdgeBatch function Oct 14, 2023
@shbone shbone changed the title Feat: add insertEdgeBatch function Feat: add insertEdgeBatch function #234 Oct 14, 2023
@CorvusYe CorvusYe self-requested a review October 14, 2023 06:40
@CorvusYe
Copy link
Collaborator

Great !
If you don't mind, could you add some author information to the pom.

@shbone shbone requested a review from CorvusYe October 14, 2023 06:54
@shbone
Copy link
Contributor Author

shbone commented Oct 14, 2023

Great ! If you don't mind, could you add some author information to the pom.

That sounds great! I will add my personal information next pr! Thank you!
And your review is so quickly!

@CorvusYe CorvusYe mentioned this pull request Oct 20, 2023
@CorvusYe CorvusYe merged commit c67c017 into nebula-contrib:master Oct 23, 2023
1 check passed
@CorvusYe CorvusYe mentioned this pull request Nov 14, 2023
@CorvusYe CorvusYe mentioned this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants