fix #73 [selectById] use id value embedding instead of cypher parameter #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cypher parameter
CorvusYe
approved these changes
Nov 1, 2022
|
Thanks @zb139407 ! BTW, @czpmango helped created this vesoft-inc/nebula#4798 but it looks like cannot catch up with the 3.3.0 release, thus we'll need this non-cypher parameter approach for quite a while. |
@wey-gu |
|
要怎么加作者信息，是关闭当前pr，重新提交吗 @CorvusYe |
当前 pr 绑定了您的 fork 的 master 分支，您把 pom.xml 修改之后直接推到 zb139407:master 就可以反映到这个pr 上了，不用关闭 pr |
先不关闭，修改一下 pom.xml 再提交一次，提交好了再关闭~ |
wey-gu
approved these changes
Nov 2, 2022
CorvusYe
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.