Remove grgit and jgit #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
commented
Oct 19, 2023
| implementation 'com.github.zafarkhaja:java-semver:0.9.0' | ||
| implementation platform("com.fasterxml.jackson:jackson-bom:2.14.2") | ||
|
|
||
| compileOnly platform("com.fasterxml.jackson:jackson-bom:2.11.0") | ||
| testImplementation 'org.eclipse.jgit:org.eclipse.jgit:5.7.0.202003110725-r' |
There was a problem hiding this comment.
This is just to keep setting up the tests easily without doing native git commands there
OdysseusLives
approved these changes
Oct 19, 2023
|
|
||
| /** | ||
| * Responsible for executing native Git commands via Gradle's ExecOperations | ||
| * This replaced grgit/jgit need and it is useful to be configuration cache compliant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove the need for grgit/jgit
Instead, we leverage native
gitviaExecin order to continue our work to support configuration cache (future PR)