Make gem work for projects with Ruby >= 2.7 and source code with UTF-8 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 27, 2021 13:48
incompatible character encodings: ASCII-8BIT and UTF-8 Taken from simplecov-ruby/simplecov#866
Fix:
ArgumentError:
wrong number of arguments (given 3, expected 2; required keywords: file_path, line_index)
# reverse_coverage-0.1.1/lib/reverse_coverage/main.rb:80:in `save_changes'
# reverse_coverage-0.1.1/lib/reverse_coverage/main.rb:35:in `block (2 levels) in add'
Contributor
Author
|
I guess this project is no longer maintained @blocknotes @DanielePalombo ? Could you update the README? |
jmgarnier
commented
Jun 29, 2023
| 'Libraries' => %r{/lib/}, | ||
| 'Interactors' => %r{/app/interactors}, | ||
| 'Services' => %r{/app/services}, | ||
| 'Validators' => %r{/app/validators}, |
Contributor
Author
There was a problem hiding this comment.
should probably removes these 3 last lines. Not standard
Member
There was a problem hiding this comment.
Yes, maybe you can add a configuration in order to customize the Categories
Contributor
Author
There was a problem hiding this comment.
It's been 2 years. I won't work on it. You can remove these lines with a new commit
Member
There was a problem hiding this comment.
I cannot edit your branch. I would prefer it if you can remove that commit and force-push the change.
DanielePalombo
requested changes
Jul 4, 2023
| 'Libraries' => %r{/lib/}, | ||
| 'Interactors' => %r{/app/interactors}, | ||
| 'Services' => %r{/app/services}, | ||
| 'Validators' => %r{/app/validators}, |
Member
There was a problem hiding this comment.
I cannot edit your branch. I would prefer it if you can remove that commit and force-push the change.
DanielePalombo
approved these changes
Jul 4, 2023
Contributor
Author
|
❤️ |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds like this projet is kind of abandoned so I'll push this PR for people who have read your excellent blog post and want to give it a try.
Thank you for sharing :)