Remove deprecated Spree::PromotionRule#for

Please select promotion rules by their applicable status on the promotable instead. Ref solidusio#4284
nebulab · Mar 27, 2023 · a8c0735 · a8c0735
1 parent e27f779
commit a8c0735
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/core/app/models/spree/promotion_rule.rb b/core/app/models/spree/promotion_rule.rb
@@ -18,11 +18,6 @@ def preload_relations
       []
     end
 
-    def self.for(promotable)
-      all.select { |rule| rule.applicable?(promotable) }
-    end
-    deprecate :for, "Please select promotion rules by their applicable status on the promotable instead."
-
     def applicable?(_promotable)
       raise NotImplementedError, "applicable? should be implemented in a sub-class of Spree::PromotionRule"
     end

diff --git a/core/spec/models/spree/promotion_spec.rb b/core/spec/models/spree/promotion_spec.rb
@@ -751,7 +751,6 @@
 
     it "true if there are no applicable rules" do
       promotion.promotion_rules = [stub_model(Spree::PromotionRule, eligible?: true, applicable?: false)]
-      allow(promotion.promotion_rules).to receive(:for).and_return([])
       expect(promotion.eligible_rules(promotable)).to eq []
     end