Collapsing sidebar fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/style-collapsing-sidebar
branch
from
24fc80d to
70f87fe
Compare
kennyadsl
force-pushed
the
mfrecchiami/style-collapsing-sidebar
branch
from
3fa5c8a to
65a017d
Compare
Flash messages wrapper element is currently being cut at the width of the standard sidebar, even when it is collapsed. This commit allows the wrapper to be displayed correctly, based on the current size of the sidebar.
At the moment they have some visual issues and the result without them is acceptable. We can add them later with a separate PR.
This section is present twice in the file. Probably one of them has been added in some rebase.
We are not using it anymore since it's not ready. It's working only for items of the upper part of the menu.
This is needed because Sticky-Kit hardcodes the width of the sticky elements into the CSS directly. When we collapse the sidebar, some of them change size and we need to invalidate the Sticky-Kit cache in order to let it recalculate the new width.
kennyadsl
force-pushed
the
kennyadsl/style-collapsing-sidebar
branch
from
70f87fe to
ff0f21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposal to fix some issues with solidusio#3322
Sidebar, I removed one of them.I'm also tempted to remove the tooltip stuff since now works only on the upper menu items, while I think we should find a better solution to have them on all items but I think it can be done in a separate PR as well. WDYT?
cc @mfrecchiami @davidedistefano