Add rake task to import current Roles to new permission system #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-krg
force-pushed
the
the-krg/add-task-to-import-permissions
branch
from
bc04003 to
50c2659
Compare
the-krg
changed the title
3 tasks
the-krg
force-pushed
the
the-krg/add-task-to-import-permissions
branch
from
50c2659 to
2e874bd
Compare
| namespace :solidus do | ||
| desc "Import existing permission sets to role permissions table" | ||
| task import_existing_permission_sets: :environment do | ||
| Spree::PermissionSets::Base.subclasses.each do |permission| |
There was a problem hiding this comment.
Should we prepend with Zeitwerk::Loader.eager_load_all? Otherwise, we might skip subclasses that haven't yet been loaded in the development environment.
Also, should we consider subclasses of subclasses?
For both questions, I'm thinking about user-defined permission sets, as they're not a problem in vanilla Solidus.
There was a problem hiding this comment.
Great suggestion!
Did some tests with custom permission sets on Sandbox and it worked.
Also changed from subclasses to descendants, so we do get subclasses of subclasses as well as permission sets inherited from other permission sets.
the-krg
force-pushed
the
the-krg/add-task-to-import-permissions
branch
from
2e874bd to
1744dc8
Compare
This commit introduces a simple rake task that imports the Permission Sets to the DB, then iterates over the defined permissions on AppConfiguration to create the RolePermissions.
the-krg
force-pushed
the
the-krg/add-task-to-import-permissions
branch
from
1744dc8 to
5adee72
Compare
the-krg
merged commit ef2de84
into
rainerd/incorporate-roles-management-code-into-the-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This rake task creates
Spree::PermissionSetrecords for each existing permission set subclass inSpree::PermissionSets::*, andSpree::RolePermissionrecords for each role's associated permission sets.(It is designed to work with both new installations and existing Solidus stores that have custom roles and permissions).
Usage