Some proposed updates / changes to nautilus #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGrulich
requested changes
Jan 14, 2025
| @@ -242,6 +257,11 @@ val<ValueType> inline operator+(val<ValueType>& left, IndexType offset) { | |||
| return left + val<size_t>(offset); | |||
| } | |||
|
|
|||
| template <is_ptr ValueType, is_integral IndexType> | |||
| val<ValueType> inline operator+(val<ValueType>& left, static_val<IndexType> offset) { | |||
There was a problem hiding this comment.
do we really need this? could this not be implemented by the cast operator of static_val?
There was a problem hiding this comment.
How would this cast be then reflected in the nautilus code?
nautilus::static_val<uint64_t> minKeyOffset = std::numeric_limits<uint64_t>::max();
for (const auto& field : nautilus::static_iterable(fields))
{
const auto offset = field.fieldOffset;
if (minKeyOffset > offset)
{
minKeyOffset = offset;
}
}
auto castedMemArea = static_cast<nautilus::val<int8_t*>>(entryRef);
/// I want this addition to be of a val<int8_t*> and a constant in the traced/compiled code
auto valueMemArea = castedMemArea + minKeyOffset;
}
keyseven123
force-pushed
the
some_changes_updates
branch
from
8cf9dd0 to
dadfe91
Compare
Also added a missing declaration in nautilus::val<ptr> so that it can be used with tracing enabled and also disabled Signed-off-by: Nils Schubert <nilslpschubert@gmail.com>
Signed-off-by: Nils Schubert <nilslpschubert@gmail.com>
keyseven123
force-pushed
the
some_changes_updates
branch
from
dadfe91 to
705925b
Compare
Signed-off-by: Nils Schubert <nilslpschubert@gmail.com>
keyseven123
force-pushed
the
some_changes_updates
branch
from
705925b to
ef602ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing some changes to nautilus that I have come across while implementing a windowed aggregation in NebulaStream.
The first commit is a breaking change and should be part of the main. For the other two commits, they are up to debate IMHO.