Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option for local config file #77

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Added option for local config file #77

merged 5 commits into from
Dec 9, 2022

Conversation

bduffey-pe
Copy link
Contributor

Solves problem from #76

@necojackarc necojackarc mentioned this pull request Dec 8, 2022
Closed
necojackarc
necojackarc requested changes Dec 9, 2022
View reviewed changes
Copy link
Owner

@necojackarc necojackarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean and good, but I'd like you to make two changes if you don't mind! Thank you so much for making a pull request 😍

.eslintrc.js
@@ -1,6 +1,6 @@
module.exports = {
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 2020,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
src/github.js Outdated Show resolved Hide resolved
necojackarc
necojackarc approved these changes Dec 9, 2022
View reviewed changes
Copy link
Owner

@necojackarc necojackarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame we don't have tests for this logic but I don't think it's a big issue. LGTM!

@necojackarc necojackarc merged commit 3fa3f27 into necojackarc:master Dec 9, 2022
@necojackarc necojackarc mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necojackarc necojackarc necojackarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bduffey-pe @necojackarc @bduff9