Add cursor: pointer; to [role="button"] to fix #371 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Address cursor inconsistency between `button` and `[role="button"]` * Work around Safari element clickability issue, at least for button-ish widgets with `[role="button"]`. Such widgets should have the role for proper accessibility anyway. See also https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile
This was referenced Feb 28, 2015
|
I think we're going to remove the pointer styles. I appreciate that there's an iOS bug; some JS frameworks fix this, otherwise it could go in app base styles if that's how you like to roll. |
cvrebert
added a commit
to twbs/bootstrap
that referenced
this pull request
Apr 22, 2015
cvrebert
added a commit
to twbs/bootstrap
that referenced
this pull request
Nov 13, 2015
This reverts commit 6106730. The normalize.css pull request (necolas/normalize.css#379 ) was REJECTED, *NOT* merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371.