Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all use of legacy context API #1506

Closed
Tracked by #2377
necolas opened this issue Dec 18, 2019 · 2 comments
Closed
Tracked by #2377

Remove all use of legacy context API #1506

necolas opened this issue Dec 18, 2019 · 2 comments
Assignees
Labels
project:react-native-web Issue associated with react-native-web

Comments

@necolas
Copy link
Owner

necolas commented Dec 18, 2019

The problem

The legacy context API is being used in a number of components. This API will eventually be deprecated and there are performance improvements to using the current context API.

@necolas necolas added this to the 0.13 milestone Apr 16, 2020
@necolas necolas modified the milestones: 0.13, 0.15 Oct 27, 2020
@necolas necolas modified the milestones: 0.15, 0.16 Dec 8, 2020
@sergeymild
Copy link

I am still seeing that problem

Warning: Legacy context API has been detected within a strict-mode tree.

The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Please update the following components: CellRenderer

Learn more about this warning here: https://reactjs.org/link/legacy-context
    at CellRenderer (http://localhost:3002/static/js/0.chunk.js:92083:36)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at http://localhost:3002/static/js/0.chunk.js:70871:34
    at ScrollView (http://localhost:3002/static/js/0.chunk.js:17993:37)
    at VirtualizedList (http://localhost:3002/static/js/0.chunk.js:90941:34)
    at FlatList (http://localhost:3002/static/js/0.chunk.js:88627:34)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at ProfileScreen (http://localhost:3002/static/js/0.chunk.js:24876:76)
    at StaticContainer (http://localhost:3002/static/js/0.chunk.js:2987:16)
    at EnsureSingleNavigator (http://localhost:3002/static/js/0.chunk.js:2697:3)
    at SceneView (http://localhost:3002/static/js/0.chunk.js:2884:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at CardSheet (http://localhost:3002/static/js/0.chunk.js:12009:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at AnimatedComponent (http://localhost:3002/static/js/0.chunk.js:85088:32)
    at AnimatedComponentWrapper
    at Dummy (http://localhost:3002/static/js/0.chunk.js:9907:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at AnimatedComponent (http://localhost:3002/static/js/0.chunk.js:85088:32)
    at AnimatedComponentWrapper
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at Card (http://localhost:3002/static/js/0.chunk.js:11251:5)
    at CardContainer (http://localhost:3002/static/js/0.chunk.js:11746:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at WebScreen (http://localhost:3002/static/js/0.chunk.js:11087:1)
    at AnimatedComponent (http://localhost:3002/static/js/0.chunk.js:85088:32)
    at AnimatedComponentWrapper
    at MaybeScreen (http://localhost:3002/static/js/0.chunk.js:11127:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at MaybeScreenContainer (http://localhost:3002/static/js/0.chunk.js:11109:3)
    at CardStack (http://localhost:3002/static/js/0.chunk.js:12211:5)
    at KeyboardManager (http://localhost:3002/static/js/0.chunk.js:10866:5)
    at SafeAreaProviderCompat (http://localhost:3002/static/js/0.chunk.js:11022:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at StackView (http://localhost:3002/static/js/0.chunk.js:12646:5)
    at StackNavigator (http://localhost:3002/static/js/0.chunk.js:9509:3)
    at EnsureSingleNavigator (http://localhost:3002/static/js/0.chunk.js:2697:3)
    at BaseNavigationContainer (http://localhost:3002/static/js/0.chunk.js:2373:3)
    at ThemeProvider (http://localhost:3002/static/js/0.chunk.js:6635:3)
    at NavigationContainer (http://localhost:3002/static/js/0.chunk.js:6345:3)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at NativeSafeAreaView (http://localhost:3002/static/js/0.chunk.js:66175:3)
    at SafeAreaProvider (http://localhost:3002/static/js/0.chunk.js:66354:3)
    at ThemeProvider (http://localhost:3002/static/js/0.chunk.js:607:31)
    at div
    at View (http://localhost:3002/static/js/0.chunk.js:76732:24)
    at App (http://localhost:3002/static/js/main.chunk.js:264:89)

@necolas necolas modified the milestones: 0.17, 0.18, 0.19 Apr 9, 2021
@necolas necolas added the project:react-native-web Issue associated with react-native-web label Jul 2, 2022
@necolas necolas self-assigned this Aug 26, 2022
@necolas necolas mentioned this issue Oct 27, 2022
9 tasks
@necolas
Copy link
Owner Author

necolas commented Nov 2, 2022

The only legacy context use left is in the React Native vendor code, e.g., VirtualizedList, and needs to be fixed upstream

@necolas necolas closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:react-native-web Issue associated with react-native-web
Projects
None yet
Development

No branches or pull requests

2 participants