0.19 dev #2377
Merged
0.19 dev #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f156ed4:
|
|
Size change: +4.06 kB
View unchanged
|
necolas
force-pushed
the
0.19-dev
branch
7 times, most recently
from
87d35b4 to
d87542b
Compare
edkimmel
reviewed
Oct 28, 2022
necolas
added a commit
that referenced
this pull request
Dec 27, 2022
Adds support for PointerEvent prop handlers and removes `onClickCapture`. Ref #2377
|
I've been juggling a dozen things recently and will need more help than in previous releases to canary test changes and find bugs. The canary currently includes many deprecation warnings. I'm also looking for feedback on that. I'm open to a couple of different approaches: Either: 0.19 is released with deprecation warnings in console; 0.20 goes out with all deprecated props/styles removed and no warnings. Or: 0.19 is released with no warnings in console; 0.20 is immediately released with all the warnings in console output; 0.21 removes all the deprecated APIs. cc @EvanBacon for Expo perspective on how disruptive different approaches might be for their SDK users. |
|
great work, really exciting stuff! |
|
Trying to use It fails when |
|
You should create an issue against react-native-paper |
|
I don't think Are you suggesting I create an issue for the |
Yep. It never did anything on web and shouldn't be imported or used in web components anymore. |
|
I understand the code doesn't do anything in the web, but it also doesn't do anything in iOS but it is implemented as a no-op: What other reasons is there for removing the BackHandler from the web? I think it sounds like a trade-off between compatibility and maintainability. |
@necolas Would be the solution use conditional import? Wouldn't that make other people's code unnecessarily complex? |
|
Please create issues against other projects so they have time to make changes before this release goes out. This PR has been open for nearly 6 months, there have been several canary releases, and ample time for testing. The release after this (0.20) will likely remove all the above-mentioned deprecated APIs entirely, so that RNWeb can get significantly smaller and faster. |
|
I don't think it will be significantly smaller and faster, in-fact it will be easier to wrap this library in the short term than to deal with this compatibility issue in every other project. By all means, remove the deprecated APIs once they are no longer available in RN. Also, correct me if I am wrong. The |
These components have been replaced by Pressable and will be removed from React Native. Fix #2382
Port ScrollView from legacy createReactClass to ES6 Class syntax.
* Add support for 'aria-*' and 'role' props. * Add support for 'id' and 'tabIndex' props. * Add support for 'pointerEvents' and 'userSelect' styles. * Deprecate 'accessibility*' props. * Deprecate 'nativeId' and 'focusable' props. * Deprecate 'pointerEvents' and 'selectable' props. Ref #2379
* Add support for 'enterKeyHint' prop. * Add support for 'inputMode' prop. * Add support for 'readOnly' prop. * Add support for 'rows' prop. * Deprecate 'keyboardType' prop. * Deprecate 'returnKeyType' prop. * Deprecate 'editable' prop. * Deprecate 'numberOfLines' prop. Ref #2379
* Add support for space-separated values. * Deprecate array values. Ref #2379
* Add support for verticalAlign style. * Deprecate textAlignVertical style. Ref #2379
Use space-separated values per W3C standard. Ref #2379
* Support logical styles like 'marginInlineStart' and 'insetInlineStart' via polyfills. * Deprecate non-standard 'marginStart' etc. properties. Ref #2379
This patch reorganizes the style compiler so that the 'preprocess' step is responsible for all the work needed to transform any non-standard CSS from React Native into a form that can be 'compiled' to rules for the CSSStyleSheet. Over time the 'preprocess' step should eventually be unnecessary as React Native aligns its APIs with CSS APIs. And any external style compilers should be able to run the 'preprocess' function over the style input to produce valid CSS as input for the compiler.
Adds support for PointerEvent prop handlers and removes `onClickCapture`. Ref #2377
Match default Text rendering in React Native. Fix #2498
Set textAlign on the default Text element. Prevents inheritance of textAlign set on a parent View. Fix #2498
|
Latest / last anticipated canary: 0.0.0-47671ca4 Planning to get 0.19 out this week barring any unexpected issues |
1 task
|
Hello @necolas First of all, thanks for this awesome lib, I have been using it for a while and it really rocks! Good job! Regarding the BackHandler, as mentioned above, I believe the purpose of this library is to provide support with react-native. And right now BackHandler is not deprecated on RN. I have tried the latest version (19) for react native web and getting the BackHandler issue. I think it would be nice to reenable support for it, since it is an API that is supported on React Native itself. |
This was referenced Mar 30, 2023
|
It would be nice align Linking api to RN before 0.19 publish :/ Deprecated Linking listeners still there... and we don't have |
|
@burakgormek no one reported that issue or submitted a PR. You should do it |
Repository owner
locked as resolved and limited conversation to collaborators
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canary:
npm install react-native-web@0.0.0-47671ca4Best compatibility:
react-native@>=0.71React 18 support
createRootsupport.Animatedto support React 18, including newAnimatedColornode.ScrollViewto Class component for React 18 support.New features
'button'and'paragraph'role to equivalent semantic HTML elements.aria-*props.roleprop.idprop.tabIndexprop (only values0and-1).pointerEventsstyle.userSelectstyle.insetInline.)<Image>support fortintColorprop.<TextInput>support forenterKeyHintprop.<TextInput>support forinputModeprop.<TextInput>support forreadOnlyprop.<TextInput>support forrowsprop.Deprecations
Touchable*components. UsePressable.Buttoncomponent. UsePressable.StyleSheet.compose(). Use style array syntax.accessibility*props. Usearia-*androleprops.nativeIdprop. Useidprop.focusableprops. UsetabIndexprop.pointerEventsprop. UsepointerEventsstyle.selectableprop. UseuserSelectstyle.fontVariantstyle array values. Use space-separated string values.textAlignVerticalstyle. UseverticalAlignstyle.transformstyle array values. Use space-separated string functions.<Image>styleresizeMode. UseresizeModeprop.<Image>styletintColor. UsetintColorprop.<TextInput>propkeyboardType. UseinputModeprop.<TextInput>propreturnKeyType. UseenterKeyHintprop.<TextInput>propeditable. UsereadOnlyprop.<TextInput>propnumberOfLines. Userowsprop.Breaking changes
setNativePropsAPI.AppState.removeListenerAPI.Fixes
Animatednow works with compiled styles.Todo:
onPointer*props.ImageDOM props