Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using DrawerLayoutAndroid on web (Removed from react-native-web) #2304

Closed
edkimmel opened this issue Nov 1, 2022 · 3 comments · Fixed by #2305
Closed

Stop using DrawerLayoutAndroid on web (Removed from react-native-web) #2304

edkimmel opened this issue Nov 1, 2022 · 3 comments · Fixed by #2305
Labels
Missing repro Platform: Web

Comments

@edkimmel
Copy link

edkimmel commented Nov 1, 2022

Description

As of the 0.19 RNW canary, the DrawerLayoutAndroid export has been removed.

The previous implementation was returning UnimplementedView, so no functionality should be tied to this module on web.

Steps to reproduce

Attempt to compile a project using react-native-gesture-handler and react-native-web@0.0.0-a825648cb.

Snack or a link to a repository

necolas/react-native-web#2377

Gesture Handler version

2.8.0

React Native version

0.69.6

Platforms

Web

JavaScript runtime

No response

Workflow

No response

Architecture

No response

Build type

No response

Device

No response

Device model

No response

Acknowledgements

Yes
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@j-piasecki j-piasecki mentioned this issue Nov 2, 2022
Merged
@jonathanj
Copy link

react-native-web 0.19.0 was released ~3 weeks ago, which unfortunately means that any attempt to use RNGH with RNW now blows up.

@iamalwayswong
Copy link

Hi! Any idea when the above PR will be merged? @j-piasecki Thanks!!

@LucioChavezFuentes LucioChavezFuentes mentioned this issue Apr 21, 2023
Closed
j-piasecki added a commit that referenced this issue Apr 24, 2023
@j-piasecki
Remove DrawerLayoutAndroid import on web (#2305)
23b74b7 
## Description

This PR removes `DrawerLayoutAndroid` from the web version of Gesture
Handler.
Should fix
#2304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Missing repro Platform: Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DrawerLayoutAndroid import on web software-mansion/react-native-gesture-handler
3 participants
@jonathanj @edkimmel @iamalwayswong