Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Image.style.tintColor and Image.style.resizeMode #2383

Closed
1 task done
necolas opened this issue Aug 28, 2022 · 0 comments
Closed
1 task done

Deprecate Image.style.tintColor and Image.style.resizeMode #2383

necolas opened this issue Aug 28, 2022 · 0 comments
Labels
enhancement Requires extension or creation of new React Native API has: pr Subject of a pull request project:react-native-web Issue associated with react-native-web
Milestone
0.19: React 18

Comments

@necolas
Copy link
Owner

necolas commented Aug 28, 2022

Is there an existing request?

  • I have searched for this request

Describe the feature request

Prepare for these non-standard styles to be removed from React Native for Web. There is already a resizeMode prop, which should be used instead. And a tintColor prop could be added, although mechanisms for color tinting images on web don't seem to work well in Safari, so the feature could be dropped entirely. Moving these features out of style will help avoid style deopts on web, and enable static extraction of styles from core components (i.e., avoid using StyleSheet.flatten during render).
@necolas necolas added enhancement Requires extension or creation of new React Native API project:react-native-web Issue associated with react-native-web labels Aug 28, 2022
@necolas necolas added this to the 0.19: React 18 milestone Aug 28, 2022
necolas added a commit that referenced this issue Aug 30, 2022
@necolas
[change] Image deprecate resizeMode and tintColor styles
9ce0284 
The resizeMode and tintColor props should be used instead. The styles
will be removed in a future release.

Fix #2383
@necolas necolas added the has: pr Subject of a pull request label Aug 30, 2022
necolas added a commit that referenced this issue Aug 30, 2022
@necolas
[change] Image deprecate resizeMode and tintColor styles
3a60bc4 
The resizeMode and tintColor props should be used instead. The styles
will be removed in a future release.

Fix #2383
necolas added a commit that referenced this issue Sep 1, 2022
@necolas
[change] Image deprecate resizeMode and tintColor styles
45e965e 
The resizeMode and tintColor props should be used instead. The styles
will be removed in a future release.

Fix #2383
necolas added a commit that referenced this issue Nov 28, 2022
@necolas
[change] Image deprecate resizeMode and tintColor styles
ff2538d 
The resizeMode and tintColor props should be used instead. The styles
will be removed in a future release.

Fix #2383
necolas added a commit that referenced this issue Dec 27, 2022
@necolas
[change] Image deprecate resizeMode and tintColor styles
6c77d8e 
The resizeMode and tintColor props should be used instead. The styles
will be removed in a future release.

Fix #2383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requires extension or creation of new React Native API has: pr Subject of a pull request project:react-native-web Issue associated with react-native-web
Projects
None yet
Milestone
0.19: React 18
Development

No branches or pull requests
1 participant
@necolas