ModalPortal - Update for new react-dom export #2784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our repo we needed to make this change in order for the Modal component to continue working with React/ReactDOM 19.1.
This pull request changes the
ModalPortalimplementation inpackages/react-native-web/src/exports/Modal/ModalPortal.jsby replacing theReactDOMimport withcreatePortaldirectly fromreact-dom. This change streamlines the code and ensures consistency in how portals are created.Code simplification:
packages/react-native-web/src/exports/Modal/ModalPortal.js: Replaced theReactDOMimport withcreatePortalfromreact-domand updated the portal creation logic to usecreatePortaldirectly. [1] [2]