Use refactor-nrepl 3.3.2 #202
Conversation
vemv
force-pushed
the
refactor-nrepl-3-3-1
branch
from
3da7487 to
4f57611
Compare
| (when-let [ns-replacement (replaceable-ns-form this filename)] | ||
| (println "Cleaning unused imports:" filename) | ||
| (write-ns-replacement! filename ns-replacement))))) | ||
| (with-memoized-libspec-allowlist |
There was a problem hiding this comment.
This macro invocation could be a strategy instead, added to the stack, but I prefered to leave something that would survive any possible refactorings (as we foresee that will happen wrt config, strategies and stuff) and clearly work no matter what.
Could be revisited later when f-s' new API becomes an actual thing
| {:style/indent 0} | ||
| [& body] | ||
| `(do | ||
| (require 'refactor-nrepl.ns.libspec-allowlist) |
There was a problem hiding this comment.
It's not available in every clojure version, so I tend not to use it in tooling projs
There was a problem hiding this comment.
F-s ships with clojure 1.10.3, so I think you're safe 😁
There was a problem hiding this comment.
Done! Also bumped r-n again for https://github.com/clojure-emacs/refactor-nrepl/blob/6529ec03c854eddcd0b62f359378d066e9d88d3d/CHANGELOG.md#332
Brief
https://github.com/clojure-emacs/refactor-nrepl/blob/bc7779fc0d25ec025486438ad0f5b0990644a742/CHANGELOG.md#330
Now refactor-nrepl honors .clj-kondo config, as far as ns cleaning goes.
Which for us is useful: it means that f-s also gets to reuse kondo config, which means a DRYer/easier experience for a variety of users.
QA plan
Author checklist
Reviewer checklist