-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default support for $COVERAGE_PROCESS_START #378
Comments
Original comment by Ionel Cristian Mărieș (Bitbucket: ionelmc, GitHub: ionelmc) Is is correct to assume this is going to be something similar to what pytest-cov has? PS. pytest-cov is going to get an upgrade to the pth installing/uninstalling thing, you might want to take a look over pytest-dev/pytest-cov#58 |
Original comment by Buck Evan (Bitbucket: bukzor, GitHub: bukzor) Correct, and I'm aware :) Ideally closing this ticket would eliminate my need for pytest-cov and cov-core. Note that cov-core#53 is filed by me. |
@bukzor I don't quite understand your three choices. In #1, you say, "throw an error". Throw it when? When trying to uninstall? In #2, again, disable it when? In any case, option #3 does sound like the a fine option to me. Leaving behind a .pth file that does nothing seems OK, especially if there's a comment there apologizing and explaining why. |
This is related (duplicate?) of #367. |
I'll close this issue, and discussion can continue on #367. |
Originally reported by Buck Evan (Bitbucket: bukzor, GitHub: bukzor)
The essential idea is that there's this nifty feature in coverage, but it's too hard to use: http://nedbatchelder.com/code/coverage/subprocess.html
Plopping the pth file in the right spot isn't straightforward code that everyone can write without flaw. It should be a (tested) part of the coveragepy project.
I have a patch for this, but want to get your design guidance before I submit it. There's an interesting fact: there's no reliable way to uninstall a pth file in the case of
easy-install
orsetup.py develop
/pip install -e
. The wheel andpip install
cases work just fine, which are (I hope!) the usual cases.Given that fact, what fallback should we (I) provide in these cases? There are three basic choices:
All three are fairly easy to implement. I just need you to pick your favorite, if you would.
The text was updated successfully, but these errors were encountered: