Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical filename for debounce library #505

Closed
nedbat opened this issue Jul 14, 2016 · 8 comments
Closed

Use canonical filename for debounce library #505

nedbat opened this issue Jul 14, 2016 · 8 comments
Labels
bug Something isn't working html

Comments

@nedbat
Copy link
Owner

nedbat commented Jul 14, 2016

Originally reported by Ben Finney (Bitbucket: bignose, GitHub: bignose)


The library “jQuery throttle / debounce” is provided using the canonical filename jquery.ba-throttle-debounce.js (or, in compiled form, with a .min.js suffix instead).

Please use the canonical name when searching for the library file, to allow easier upgrade and management of the library.


@nedbat
Copy link
Owner Author

nedbat commented Jul 14, 2016

Original comment by Ben Finney (Bitbucket: bignose, GitHub: bignose)


My suggested solution for this is in the fork at https://vcs.whitetree.org/hg/python/coveragepy/devel/ — revision 3006–3008.

  • Name the debounce library to the canonical upstream filename.
  • Correct references to the debounce library file.

@nedbat
Copy link
Owner Author

nedbat commented Jul 14, 2016

That vcs.whitetree.org URL seems to have nothing interesting, just a link to a parent directory?

@nedbat
Copy link
Owner Author

nedbat commented Jul 14, 2016

Original comment by Ben Finney (Bitbucket: benf_wspdigital, GitHub: Unknown)


That vcs.whitetree.org URL seems to have nothing interesting

To a web browser, right. But to Mercurial it contains a repository. It will work fine with hg incoming, etc.

@nedbat
Copy link
Owner Author

nedbat commented Jul 26, 2016

Tried to clone it:

$ hg clone https://vcs.whitetree.org/hg/python/coveragepy/devel/
destination directory: devel
requesting all changes
adding changesets
adding manifests
adding file changes
transaction abort!
rollback completed
abort: missing support for negative part header size: -1

Can you put your changes somewhere more accessible? A pull request perhaps?

@nedbat
Copy link
Owner Author

nedbat commented Jul 27, 2016

Original comment by Ben Finney (Bitbucket: bignose, GitHub: bignose)


Here is a Mercurial bundle of the changeset I created to resolve this issue.

You apply a Mercurial bundle using the unbundle command.

@nedbat
Copy link
Owner Author

nedbat commented Jul 28, 2016

Merged in 7c3dddfe8389 (bb)

@nedbat
Copy link
Owner Author

nedbat commented Jul 28, 2016

Closes issue #505

→ <<cset 7c3dddfe8389 (bb)>>

@nedbat
Copy link
Owner Author

nedbat commented Dec 27, 2016

This fix was released as part of Coverage.py 4.3.

@nedbat nedbat closed this as completed Dec 27, 2016
@nedbat nedbat added minor bug Something isn't working html labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html
Projects
None yet
Development

No branches or pull requests

1 participant