-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Erase" still needed in 4.2 #510
Comments
@butla Can you provide me with a reproducible scenario? I tried running your tests, and got many errors like this: I see that you used to have two "coverage erase" lines and now you have only one? |
Original comment by Michał Bultrowicz (Bitbucket: Butla, GitHub: Butla) @nedbat Well, the tests require Docker. I have Xubuntu 14.04 with Docker 1.6.2 installed. If you don't want to setup Docker, you can use a Vagrant box with Docker (this of course requires Vagrant and Virtualbox):
Is this OK or should I provide a simpler scenario? About two "coverage erase" - yes, I needed two and I reported this behavior in #492, but it's fixed in 4.2. |
Hmm, the problem is that "tox" and "pylint" each run with coverage measurement (because of coverage_pth), and they each read the .coverage file before running. This carries the .coverage data into a parallel .coverage.localhost.xxx file, which then gets combined by the combine step. Seems like reading the .coverage file during auto-started coverage measurement is a bad thing. |
The recent auto_load changes fixed #510 → <<cset fee2fd97520c (bb)>> |
This is fixed in the handful of commits ending with fee2fd97520c (bb) |
This fix was released as part of Coverage.py 4.3. |
Originally reported by Michał Bultrowicz (Bitbucket: Butla, GitHub: Butla)
If I understand http://nedbatchelder.com/blog/201607/coveragepy_42.html correctly, then running "run" and then "combine" (I'm running parallel tests) should properly detect loss of test coverage, right? Because they shouldn't look at the old .coverage by default.
But at the moment I still need to run "erase" to get rid of the old results before running the tests.
Here's my full tox.ini: https://github.com/butla/PyDAS/blob/a8c76d3221447fb34af60f5d03b18df52286ed4c/tox.ini
The text was updated successfully, but these errors were encountered: