-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config snippets in code exclusion docs #1917
Conversation
"@(abc\\.)?abstractmethod", | ||
] | ||
'class .*\bProtocol\):', | ||
'@(abc\.)?abstractmethod', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that single- and double-quotes have different semantics. I would rather use single quotes for all strings instead of mixing the styles.
Also, make sure the cog process that produces the files still works properly. You need to run make cogdoc
to be sure.
Thanks. Looks like there are also places in config.rst to fix. |
Or, let me know if you'd like me to take care of that. |
If you have time, that would be great! Otherwise I'll try to get back to this later in the week. |
2a410f5
to
601bc44
Compare
I found some time - the CI commands are passing locally now. |
Thanks. Let me know when you are done with it. Do you want to put all the exclusions in single quotes for consistency? |
Sure, I guess that makes sense - whichever of us finds the time first 🙂 |
601bc44
to
a117d88
Compare
Done - GTM? |
a117d88
to
1ef7cc2
Compare
This PR makes some improvements to the code snippets in the "Excluding code from coverage.py" docs.