Workaround issue with relpath on Windows #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #895.
Writing a non-regression test for this is going to be tricky. It might be possible using https://stackoverflow.com/a/827398/163740 to see if there is another drive / mount available on the CI machine and
chdir
to it before writing the coverage file but it's complicated.Let me know if you want me to try to write such a non-regression test or not.
Besides, I have tested this branch on the scikit-learn CI scikit-learn/scikit-learn#15909 and confirms that this fixes the original problem.