Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround issue with relpath on Windows #896

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Dec 18, 2019

Fix for #895.

Writing a non-regression test for this is going to be tricky. It might be possible using https://stackoverflow.com/a/827398/163740 to see if there is another drive / mount available on the CI machine and chdir to it before writing the coverage file but it's complicated.

Let me know if you want me to try to write such a non-regression test or not.

Besides, I have tested this branch on the scikit-learn CI scikit-learn/scikit-learn#15909 and confirms that this fixes the original problem.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #896 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage    94.2%   94.22%   +0.01%     
==========================================
  Files          86       86              
  Lines       11852    11870      +18     
  Branches     1182     1185       +3     
==========================================
+ Hits        11165    11184      +19     
+ Misses        560      558       -2     
- Partials      127      128       +1
Impacted Files Coverage Δ
coverage/sqldata.py 92.93% <50%> (-0.4%) ⬇️
tests/helpers.py 100% <0%> (ø) ⬆️
coverage/control.py 91.68% <0%> (+0.02%) ⬆️
tests/test_concurrency.py 96.33% <0%> (+0.21%) ⬆️
coverage/inorout.py 72.91% <0%> (+0.41%) ⬆️
tests/conftest.py 96.42% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3875113...a6b674f. Read the comment docs.

@ogrisel
Copy link
Contributor Author

ogrisel commented Dec 18, 2019

The travis failure is:

worker 'gw2' crashed while running 'tests/test_oddball.py::RecursionTest::test_long_recursion'

It seems unrelated to this PR.

@ogrisel
Copy link
Contributor Author

ogrisel commented Dec 18, 2019

@nedbat please let me know if you need anything else from my side.

@nedbat
Copy link
Owner

nedbat commented Dec 19, 2019

Looks great, thanks. I'll amend the commit to add changelog and bug number info.

@nedbat nedbat merged commit b660ba6 into nedbat:master Dec 19, 2019
@ogrisel ogrisel deleted the windows-safe-relpath branch December 19, 2019 19:21
@ogrisel
Copy link
Contributor Author

ogrisel commented Dec 19, 2019

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants