Skip to content

Defer check for valid django.template.backends.django.DjangoTemplates #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2017

Conversation

PamelaM
Copy link
Collaborator

@PamelaM PamelaM commented Jan 20, 2017

Until django.template.backends.django has been imported.

@nedbat
Copy link
Owner

nedbat commented Jan 20, 2017

Nice commit message :) I made you a collaborator if you want to merge these yourself. Looks good to me: 👍

@PamelaM
Copy link
Collaborator Author

PamelaM commented Jan 20, 2017

Classic working at home commit message:

  1. Plan to type out "Fix bug that... etc"
  2. Type "Fix bug"
  3. Get interrupted
  4. Hit return
  5. Say "D'oh!" :)

@PamelaM
Copy link
Collaborator Author

PamelaM commented Jan 20, 2017

This will fix the immediate issue (the travis tests pass, except for django10tip because someone checked in a py3-only reference to lru_cache). So I'm merging.

I think we can create a new release that will fix most of the normal cases, but might still cause problems with projects that don't use DjangoTemplates but still use some other templating system.

I've got a test_project kind of in place, but I want to automate it's creation so that it will work with all supported django versions. I need to add a testing-only dependency on jinja2 or some even more obscure template engine to confirm that the plugin works in the face of django.template.backends.django never getting imported, but a template file attempts to get coverage, etc.

@PamelaM PamelaM merged commit cc3d52a into nedbat:master Jan 20, 2017
@nedbat
Copy link
Owner

nedbat commented Jan 20, 2017

Find me on IRC if you want to talk through any of that stuff. If not, charge on! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants