-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the current CHANGELOG newlines #14
Comments
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 13, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 13, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 13, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 13, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 14, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 14, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 14, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 14, 2020
kurtmckee
added a commit
to kurtmckee/pr-scriv
that referenced
this issue
Dec 14, 2020
nedbat
pushed a commit
that referenced
this issue
Dec 14, 2020
nedbat
pushed a commit
that referenced
this issue
Dec 14, 2020
This is now available in scriv 0.10.0 |
Ned, this is great news. Thank you so much for releasing this fix! Happy holidays!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ned, thanks so much for creating scriv! I'm working to implement it for the feedparser project and I'm very pleased with it in my preliminary testing!
I have found a potential improvement opportunity: it appears that scriv is assuming my files use Windows newlines (CRLF), but I've configured git to checkout as-is. Consequently, all of my development is done using LF-only newlines regardless of platform.
However,
scriv collect
is rewriting my changelog newlines using CRLF. It looks like this is happening incollect.py
, where scriv usespathlib.Path.read_text()
andpathlib.Path.write_text()
. Both of these functions end up callingopen()
withnewline=None
, which is where there's an opportunity to improve this situation.I'm going to work to fix this and submit a PR. Please let me know if you've got a strong opinion about how to proceed, or if this type of change isn't welcome. Otherwise I'll submit a PR and wait for your review.
Thanks again for creating this tool!
The text was updated successfully, but these errors were encountered: