Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the current CHANGELOG newlines #14

Closed
kurtmckee opened this issue Dec 12, 2020 · 2 comments
Closed

Respect the current CHANGELOG newlines #14

kurtmckee opened this issue Dec 12, 2020 · 2 comments

Comments

@kurtmckee
Copy link
Contributor

Ned, thanks so much for creating scriv! I'm working to implement it for the feedparser project and I'm very pleased with it in my preliminary testing!

I have found a potential improvement opportunity: it appears that scriv is assuming my files use Windows newlines (CRLF), but I've configured git to checkout as-is. Consequently, all of my development is done using LF-only newlines regardless of platform.

However, scriv collect is rewriting my changelog newlines using CRLF. It looks like this is happening in collect.py, where scriv uses pathlib.Path.read_text() and pathlib.Path.write_text(). Both of these functions end up calling open() with newline=None, which is where there's an opportunity to improve this situation.

I'm going to work to fix this and submit a PR. Please let me know if you've got a strong opinion about how to proceed, or if this type of change isn't welcome. Otherwise I'll submit a PR and wait for your review.

Thanks again for creating this tool!

kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 13, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 13, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 13, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 13, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 14, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 14, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 14, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 14, 2020
kurtmckee added a commit to kurtmckee/pr-scriv that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
nedbat pushed a commit that referenced this issue Dec 14, 2020
@nedbat nedbat closed this as completed in 4a8d72a Dec 14, 2020
@nedbat
Copy link
Owner

nedbat commented Dec 28, 2020

This is now available in scriv 0.10.0

@kurtmckee
Copy link
Contributor Author

kurtmckee commented Dec 28, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants