Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stable anchors for sections with versions. #47

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Add stable anchors for sections with versions. #47

merged 3 commits into from
Mar 18, 2022

Conversation

maxking
Copy link
Contributor

@maxking maxking commented Mar 14, 2022

Fixes #46

@maxking maxking mentioned this pull request Mar 14, 2022
Closed
nedbat
nedbat reviewed Mar 18, 2022
View reviewed changes
src/scriv/format_rst.py Outdated Show resolved Hide resolved
@nedbat
Copy link
Owner

nedbat commented Mar 18, 2022

Thanks! I wondered whether Markdown should get something similar, and also whether a date-only entry should get an anchor, but those are improvements that can follow on.

@nedbat nedbat merged commit 140a65f into nedbat:main Mar 18, 2022
@nedbat
Copy link
Owner

nedbat commented Mar 19, 2022

Oops: this adds the .rst anchor to .md files also....

@nedbat
Copy link
Owner

nedbat commented Mar 19, 2022

I fixed the problem in 63fc528, and also have anchors for .md files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedbat nedbat nedbat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create stable URLs to changelogs
2 participants
@maxking @nedbat