Skip to content

Commit f972892

Browse files
authored
Created alert-box and changed file-name for barometer (fossasia#1340)
1 parent e878430 commit f972892

File tree

4 files changed

+34
-11
lines changed

4 files changed

+34
-11
lines changed

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<activity android:name=".activity.AccelerometerActivity" />
7878
<activity android:name=".activity.DataLoggerActivity" />
7979
<activity
80-
android:name=".activity.Barometer_activity"
80+
android:name=".activity.BarometerActivity"
8181
android:configChanges="keyboardHidden|screenSize|orientation" />
8282
<activity
8383
android:name=".activity.CompassActivity"

app/src/main/java/io/pslab/activity/Barometer_activity.java renamed to app/src/main/java/io/pslab/activity/BarometerActivity.java

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.pslab.activity;
22

33
import android.annotation.SuppressLint;
4+
import android.content.DialogInterface;
45
import android.content.SharedPreferences;
56
import android.graphics.Color;
67
import android.hardware.Sensor;
@@ -11,6 +12,7 @@
1112
import android.os.Handler;
1213
import android.support.annotation.NonNull;
1314
import android.support.design.widget.BottomSheetBehavior;
15+
import android.support.v7.app.AlertDialog;
1416
import android.support.v7.app.AppCompatActivity;
1517
import android.os.Bundle;
1618
import android.view.GestureDetector;
@@ -47,15 +49,15 @@
4749
import butterknife.ButterKnife;
4850
import butterknife.Unbinder;
4951

50-
public class Barometer_activity extends AppCompatActivity {
52+
public class BarometerActivity extends AppCompatActivity {
5153
BottomSheetBehavior bottomSheetBehavior;
5254
GestureDetector gestureDetector;
5355
private static final String PREF_NAME = "customDialogPreference";
5456

5557
private static int sensorType = 0;
5658
private static int highLimit = 1000;
5759
private static int updatePeriod = 100;
58-
private Barometer_activity.SensorDataFetch sensorDataFetch;
60+
private BarometerActivity.SensorDataFetch sensorDataFetch;
5961

6062
@BindView(R.id.barometer_max)
6163
TextView statMax;
@@ -101,8 +103,8 @@ public class Barometer_activity extends AppCompatActivity {
101103
@BindView(R.id.custom_dialog_desc)
102104
TextView bottomSheetDesc;
103105

104-
public static Barometer_activity newInstance() {
105-
return new Barometer_activity();
106+
public static BarometerActivity newInstance() {
107+
return new BarometerActivity();
106108
}
107109

108110
@SuppressLint("ResourceType")
@@ -112,14 +114,33 @@ protected void onCreate(Bundle savedInstanceState) {
112114
setContentView(R.layout.activity_barometer_main);
113115
ButterKnife.bind(this);
114116
setUpBottomSheet();
115-
Barometer_activity.newInstance();
117+
BarometerActivity.newInstance();
116118

117119
currentMin = 10000;
118120
entries = new ArrayList<>();
119121
switch (sensorType) {
120122
case 0:
121123
sensorManager = (SensorManager) getSystemService(SENSOR_SERVICE);
122124
sensor = sensorManager != null ? sensorManager.getDefaultSensor(Sensor.TYPE_PRESSURE) : null;
125+
if (sensor == null) {
126+
runOnUiThread(new Runnable() {
127+
@Override
128+
public void run() {
129+
if (!isFinishing()) {
130+
new AlertDialog.Builder(BarometerActivity.this)
131+
.setTitle(R.string.barometer_alert_title)
132+
.setMessage(R.string.barometer_alert_description)
133+
.setCancelable(false)
134+
.setPositiveButton("ok", new DialogInterface.OnClickListener() {
135+
@Override
136+
public void onClick(DialogInterface dialog, int which) {
137+
dialog.dismiss();
138+
}
139+
}).show();
140+
}
141+
}
142+
});
143+
}
123144
break;
124145
case 1:
125146
scienceLab = ScienceLabCommon.scienceLab;
@@ -228,9 +249,9 @@ public void run() {
228249
}
229250

230251
public static void setParameters(int sensorType, int highLimit, int updatePeriod) {
231-
Barometer_activity.sensorType = sensorType;
232-
Barometer_activity.highLimit = highLimit;
233-
Barometer_activity.updatePeriod = updatePeriod;
252+
BarometerActivity.sensorType = sensorType;
253+
BarometerActivity.highLimit = highLimit;
254+
BarometerActivity.updatePeriod = updatePeriod;
234255
}
235256

236257

app/src/main/java/io/pslab/fragment/InstrumentsFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import io.pslab.activity.WaveGeneratorActivity;
2727
import io.pslab.adapters.ApplicationAdapter;
2828
import io.pslab.items.ApplicationItem;
29-
import io.pslab.activity.Barometer_activity;
29+
import io.pslab.activity.BarometerActivity;
3030

3131
import java.util.ArrayList;
3232
import java.util.List;
@@ -93,7 +93,7 @@ public void onItemClick(ApplicationItem item) {
9393
startActivity(intent);
9494
break;
9595
case "Barometer":
96-
intent = new Intent(context, Barometer_activity.class);
96+
intent = new Intent(context, BarometerActivity.class);
9797
startActivity(intent);
9898
break;
9999
case "Compass":

app/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -896,6 +896,8 @@
896896
GND. You can use any of the PSLab device GND pins.\n</string>
897897

898898
<string name="barometer">Barometer</string>
899+
<string name="barometer_alert_title">No barometer sensor in device</string>
900+
<string name="barometer_alert_description">Connect a BMP180 sensor using I2C pins on PSLab to use this instrument</string>
899901
<string name="barometer_description">Measures the atmospheric pressure</string>
900902
<string name="barometer_intro">\u2022 The Barometer can be used to measure Atmospheric pressure. This instrument
901903
is compatible with either the built in pressure sensor on any android device or the BMP-180 pressure sensor.\n\n

0 commit comments

Comments
 (0)