feat: created alert box for barometer and changed the file name #1340

abhinavraj23 · 2018-08-08T18:55:19Z

Changes:
Added the alert-box for pressure sensor in barometer and changed the file name from Barometer_activity to BarometerActivity

Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a *.gif containing a demonstration]

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
I have reformatted code in every file included in this PR [CTRL+ALT+L]
My code does not contain any extra lines or extra spaces
I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]
barometer.apk.zip

CloudyPadmal · 2018-08-08T23:22:08Z

app/src/main/res/values/strings.xml

    <string name="barometer_description">Measures the pressure of the atmosphere</string>
    <string name="barometer">Barometer</string>
+    <string name="barometer_alert_title">Sensor Not Present</string>
+    <string name="barometer_alert_description">Atmospheric pressure sensor is not present in your device, you need to use external sensor with PSLab for barometer</string>


Shall we use A barometer instead of Atmospheric pressure sensor?

Can we have external sensor with PSLab for barometer to work. instead of external sensor with PSLab for barometer?

CloudyPadmal · 2018-08-08T23:22:27Z

app/src/main/java/io/pslab/activity/BarometerActivity.java

+                                        .setPositiveButton("ok", new DialogInterface.OnClickListener() {
+                                            @Override
+                                            public void onClick(DialogInterface dialog, int which) {
+


Also do some refactoring here

yatri1609 · 2018-08-09T06:44:01Z

app/src/main/res/values/strings.xml

    <string name="barometer_description">Measures the pressure of the atmosphere</string>
    <string name="barometer">Barometer</string>
+    <string name="barometer_alert_title">Sensor Not Present</string>
+    <string name="barometer_alert_description">Atmospheric pressure sensor is not present in your device, you need to use external sensor with PSLab for barometer</string>


Can we have external sensor with PSLab for barometer to work. instead of external sensor with PSLab for barometer?

abhinavraj23 · 2018-08-09T06:55:25Z

@CloudyPadmal Changes done 👍 , @yatri1609 I think mentioning PSLab will make sense to the users. What do you think about this @CloudyPadmal .

abhinavraj23 · 2018-08-10T04:08:40Z

@CloudyPadmal @harsh-2711 @Avjeet @yatri1609 Please review

CloudyPadmal · 2018-08-10T04:14:47Z

app/src/main/res/values/strings.xml


    <string name="barometer">Barometer</string>
+    <string name="barometer_alert_title">Sensor Not Present</string>
+    <string name="barometer_alert_description">Barometer sensor is not present in your device, you need to use external sensor with PSLab for barometer</string>


How about;

you need to use an external sensor (BMP180) with PSLab to use this instrument

Yes I think it makes more sense.

abhinavraj23 · 2018-08-10T06:43:46Z

@CloudyPadmal Changes done 👍

abhinavraj23 · 2018-08-11T09:36:04Z

@CloudyPadmal @harsh-2711 @Avjeet Please review asap

harsh-2711 · 2018-08-11T09:50:29Z

app/src/main/res/values/strings.xml


    <string name="barometer">Barometer</string>
+    <string name="barometer_alert_title">Sensor Not Present</string>
+    <string name="barometer_alert_description">Barometer sensor is not present in your device, you need to use external sensor(BMP180) with PSLab for barometer</string>


This line isn't proper. You could rather use
"Barometer sensor is not present in your device. Please connect an external sensor(BMP180) with the PSLab I2C pin for using Barometer instrument"

Sure @harsh-2711 , I will make the change:+1

abhinavraj23 · 2018-08-11T10:26:03Z

@harsh-2711 Changes done, please review 👍

cweitat · 2018-08-11T11:30:23Z

@Avjeet Too lengthy.

No barometer sensor is detected. -line break- Connect an external sensor (BMP180) to I2C pin on PSLab..

Centralise and justify the text

cweitat · 2018-08-11T11:33:23Z

@abhinavraj23 also, what's the priority for this instrument? If both phone and PSLab have the sensors, from which device will it take the readings from?

abhinavraj23 · 2018-08-11T11:48:13Z

@cweitat currently it is only implemented by mobile sensors and and not through external sensor as there are issues in i2c communication library. But very few devices have pressure sensors(it is not common) so we should add the alert-box as the user can get confuse

cweitat · 2018-08-11T11:52:19Z

@abhinavraj23 so which means by default the alert box will appear?
If by default the alert box will appear then change the message to just

Please connect an external sensor (BMP180) to I2C pin on PSLab.

Because if the phone has the sensor then this alert box won't show. This alert box only shown when no sensor is found.

abhinavraj23 · 2018-08-11T12:13:27Z

In those devices in which the mobile sensor is not present ( i.e in most of the devices). But not adding the alert-box will make an impression on the users that the app itself is not working, which is not true as the app is working fine for the mobile sensors.

cweitat · 2018-08-11T13:42:43Z

@abhinavraj23 I'm not saying to remove the alert box. I'm saying that the alert box won't show if there is a mobile or external sensor detected.

abhinavraj23 · 2018-08-11T15:30:17Z

@cweitat if we just display

Please connect an external sensor (BMP180) to I2C pin on PSLab.

Then the user will not get the understanding that the mobile sensor is not present in his device. Will that be okay?

cweitat · 2018-08-11T18:11:37Z

Then this

No barometer sensor in device. -line break- Connect an sensor (BMP180) to I2C pin on PSLab..

abhinavraj23 · 2018-08-12T05:32:45Z

@cweitat Changes done please review 👍

abhinavraj23 · 2018-08-12T05:34:29Z

cweitat · 2018-08-12T07:54:04Z

Justify the text
Text change to

Connect an BMP180 sensor to I2C pin on PSLab to use this instrument.

abhinavraj23 · 2018-08-12T13:00:30Z

Changes done @cweitat. Please review 👍

CloudyPadmal · 2018-08-12T14:28:49Z

app/src/main/res/values/strings.xml


    <string name="barometer">Barometer</string>
+    <string name="barometer_alert_title">No barometer sensor in device</string>
+    <string name="barometer_alert_description">Connect a BMP180 sensor to I2C pin on PSLab to use this instrument</string>


Connect a BMP180 sensor using I2C pins on PSLab to use this instrument

abhinavraj23 · 2018-08-12T14:34:38Z

@CloudyPadmal changes done please review 👍

CloudyPadmal

Nice

abhinavraj23 requested review from Avjeet, CloudyPadmal and harsh-2711 and removed request for CloudyPadmal August 8, 2018 18:55

abhinavraj23 self-assigned this Aug 8, 2018

abhinavraj23 added the Status: Review Required Requested reviews from peers and maintainers label Aug 8, 2018

abhinavraj23 changed the title ~~Created alert box for barometer and changed the file name~~ feat: created alert box for barometer and changed the file name Aug 8, 2018

yatri1609 approved these changes Aug 8, 2018

View reviewed changes

CloudyPadmal requested changes Aug 8, 2018

View reviewed changes

cweitat added the Status: Conflicts Merge conflicts blocking reviews and merges label Aug 9, 2018

yatri1609 suggested changes Aug 9, 2018

View reviewed changes

abhinavraj23 removed the Status: Conflicts Merge conflicts blocking reviews and merges label Aug 9, 2018

CloudyPadmal requested changes Aug 10, 2018

View reviewed changes

yatri1609 approved these changes Aug 11, 2018

View reviewed changes

harsh-2711 suggested changes Aug 11, 2018

View reviewed changes

CloudyPadmal requested changes Aug 12, 2018

View reviewed changes

Created alert-box and changed file-name for barometer

b1fa689

CloudyPadmal approved these changes Aug 12, 2018

View reviewed changes

abhinavraj23 merged commit 6c81563 into fossasia:development Aug 12, 2018

abhinavraj23 deleted the barometer_alertbox branch October 1, 2018 06:51

CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Dec 13, 2018

neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019

Created alert-box and changed file-name for barometer (fossasia#1340)

f972892

feat: created alert box for barometer and changed the file name #1340

feat: created alert box for barometer and changed the file name #1340

Uh oh!

Conversation

abhinavraj23 commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinavraj23 commented Aug 9, 2018

Uh oh!

abhinavraj23 commented Aug 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinavraj23 commented Aug 10, 2018

Uh oh!

abhinavraj23 commented Aug 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinavraj23 commented Aug 11, 2018

Uh oh!

cweitat commented Aug 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cweitat commented Aug 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhinavraj23 commented Aug 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cweitat commented Aug 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhinavraj23 commented Aug 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cweitat commented Aug 11, 2018

Uh oh!

abhinavraj23 commented Aug 11, 2018

Uh oh!

cweitat commented Aug 11, 2018

Uh oh!

abhinavraj23 commented Aug 12, 2018

Uh oh!

abhinavraj23 commented Aug 12, 2018

Uh oh!

cweitat commented Aug 12, 2018

Uh oh!

abhinavraj23 commented Aug 12, 2018

Uh oh!

CloudyPadmal Aug 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinavraj23 commented Aug 12, 2018

Uh oh!

CloudyPadmal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abhinavraj23 commented Aug 8, 2018 •

edited

Loading

cweitat commented Aug 11, 2018 •

edited

Loading

cweitat commented Aug 11, 2018 •

edited

Loading

abhinavraj23 commented Aug 11, 2018 •

edited

Loading

cweitat commented Aug 11, 2018 •

edited

Loading

abhinavraj23 commented Aug 11, 2018 •

edited

Loading

CloudyPadmal Aug 12, 2018 •

edited

Loading