Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise memory handling with output report #22

Closed
nefarius opened this issue Mar 20, 2021 · 0 comments
Closed

Optimise memory handling with output report #22

nefarius opened this issue Mar 20, 2021 · 0 comments
Labels
enhancement New feature or request USB USB-related (wired)
Milestone
Fixed in v1.1.x

Comments

@nefarius
Copy link
Owner

Ever since switching to the Interrupt OUT Endpoint the Output Report memory blob should also contain the now necessary Report ID 0x01, so extend the context memory and get rid of this unnecessary alloc/copy/free instruction.

Update all buffer offsets in the helper macros and functions regarding USB and it should be fine.
@nefarius nefarius added the enhancement New feature or request label Mar 20, 2021
@nefarius nefarius added this to the Fixed in v1.1.x milestone Mar 20, 2021
@nefarius nefarius added the USB USB-related (wired) label Mar 20, 2021
@nefarius nefarius changed the title [USB] Optimise memory handling with output report Optimise memory handling with output report Mar 20, 2021
Kanuan pushed a commit to Kanuan/DsHidMini that referenced this issue Mar 23, 2021
@nefarius @Kanuan
Fixed nefarius#22
22ed630 
Reworked and improved memory management on sending Output Reports on USB
Kanuan pushed a commit to Kanuan/DsHidMini that referenced this issue Mar 24, 2021
@nefarius @Kanuan
Fixed nefarius#22
73837cf 
Reworked and improved memory management on sending Output Reports on USB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request USB USB-related (wired)
Projects
None yet
Milestone
Fixed in v1.1.x
Development

No branches or pull requests
1 participant
@nefarius