Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On DS4Windows Mode, the pairing attempt check will always be marked as failed #86

Closed
Kanuan opened this issue May 11, 2021 · 8 comments
Closed
Assignees
Labels
bug Something isn't working Core Core/Common Driver Topic

Comments

@Kanuan
Copy link
Collaborator

Kanuan commented May 11, 2021

On the new, yet unreleased DS4Windows mode, the last pairing attempt will always result in a fail, at least according to DSHMC.
Don't know if the pairing is actually failing or if DSHMC is just failing to properly check its status

image

@Kanuan Kanuan changed the title On DS4Windows Mode, the pairing attempt will always be marked as failed On DS4Windows Mode, the pairing attempt check will always be marked as failed May 11, 2021
@nefarius nefarius self-assigned this May 11, 2021
@nefarius
Copy link
Owner

That was probably me during the last major refactoring run, I remember touching that function. I'll look through the differences and see what I can do. Thanks!

@nefarius
Copy link
Owner

Oh, or is it really mode-dependant?

@Kanuan
Copy link
Collaborator Author

Kanuan commented May 11, 2021

Oh, or is it really mode-dependant?

It is, other modes are unaffected

@nefarius
Copy link
Owner

Oh, or is it really mode-dependant?

It is, other modes are unaffected

Interesting, that is indeed a new puzzle then. I'll check it out.

@nefarius nefarius added bug Something isn't working Core Core/Common Driver Topic labels May 11, 2021
@nefarius
Copy link
Owner

Can you check the property what the exact error code is in your case?

image

Because I got it now as well while plugging it in (in new XInput mode):

image

@nefarius
Copy link
Owner

I assume this is the culprit; for this occasion the status should be set to STATUS_SUCCESS explicitly or it will write STATUS_UNSUCCESSFUL to the property value.

@Kanuan
Copy link
Collaborator Author

Kanuan commented May 11, 2021

Can you check the property what the exact error code is in your case?

It's the exact same as yours

@nefarius
Copy link
Owner

Can you check the property what the exact error code is in your case?

It's the exact same as yours

Then I am quite certain this is the case. I added the check in the refactoring, to avoid re-pairing to the same radio which avoids sending an unnecessary packet.

@nefarius nefarius added this to the Fixed in v1.4.x milestone May 11, 2021
nefarius added a commit that referenced this issue May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Core/Common Driver Topic
Projects
None yet
Development

No branches or pull requests

2 participants