Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked rumble configuration and processing #354

Merged
merged 13 commits into from
Apr 25, 2024

Conversation

Kanuan
Copy link
Collaborator

@Kanuan Kanuan commented Apr 24, 2024

  • Changed the structure of user defined rumble configurations
  • Updated rumble configuration loading from disk to fit changes
  • Re-purposed structure that store last received rumble intensities to also store current state of rumble rescaling
    • Before the current state was read/write directly to the user configurations
  • Added a IsAllowed property for the current state of rumble rescalers so rescaling can be "blocked" even if it's enabled
    • Set to false if user-defined rescaling ranges are invalid
  • Reworked rumble processing to reflect changes above
    • Rescaling constants, if they are enabled and if they are allowed are now fetched from the re-purposed struct commented above
  • Changed rumble processing logic so motors can only be disabled while in normal mode

@Kanuan
Copy link
Collaborator Author

Kanuan commented Apr 25, 2024

I confirm everything is working as expected

@nefarius nefarius merged commit da4ed11 into nefarius:master Apr 25, 2024
1 check passed
@nefarius nefarius added this to the Version 3 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants