feat: "Copy link" button in Export dialog #366
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/4zur6uvmw |
| <Popover placement={popoverPlacement} open={popoverOpen} target={popoverTarget} ontoggle={closePopover}> | ||
| <PopoverHeader>{popoverHeader}</PopoverHeader> | ||
| <PopoverBody>{popoverBody}</PopoverBody> | ||
| </Popover> |
There was a problem hiding this comment.
Doesn't show up (but doesn't break the app either 😄 ).
Anyone knows why?
There was a problem hiding this comment.
Because we are already in a popover? I think this particular implementation is modal, that means there could be only one.
Maybe we could just change the button's text and/or add a green checkmark somewhere? (on successful copy)
|
This functionality is very much welcome. I've been getting sick of trying to copy our absurdely long URLs. I fully approve merging this but I'll let @ivan-aksamentov take a quick look as it adds a dependency. |
|
@nnoll as for dependency, it’s for this single line:
This is because Popover we’re using internally uses Poper and uses this enum. I could have copied this enum manually, but I think this is more decent since Popper seems to be already bundled into our solution. |
| <Popover placement={popoverPlacement} open={popoverOpen} target={popoverTarget} ontoggle={closePopover}> | ||
| <PopoverHeader>{popoverHeader}</PopoverHeader> | ||
| <PopoverBody>{popoverBody}</PopoverBody> | ||
| </Popover> |
There was a problem hiding this comment.
Because we are already in a popover? I think this particular implementation is modal, that means there could be only one.
Maybe we could just change the button's text and/or add a green checkmark somewhere? (on successful copy)
|
@ivan-aksamentov so popover in modal isn't doable? I'm googling and seeing others have similar problem. Huh... |
|
@ivan-aksamentov I decided just to change the button text, as suggested 😃
|
|
Could this be merged? The popover has been removed as suggested.. |
Related issues and PRs
Description
Encourages the user to copy the link and share it via email etc.
Impacted Areas in the application
Export dialog.
Testing
Video: https://microsofteur-my.sharepoint.com/:i:/g/personal/dakozar_microsoft_com/ES8jveSoVLNAukRCgZ6GCAYBKYsdab8Ll8CTnz8g9QXq6g?e=YnyQ4b