Skip to content

Commit

Permalink
Fix persistence visibility test
Browse files Browse the repository at this point in the history
  • Loading branch information
neil-xie committed Jan 21, 2025
1 parent e724a41 commit 9c7eba0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions common/persistence/client/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ func (f *factoryImpl) NewVisibilityManager(
"os": visibilityFromOS,
}
if params.OSConfig.Migration.Enabled {
// this should be always true when using os-visibility
visibilityFromES, err = setupESVisibilityManager(params, resourceConfig, f.logger)
if err != nil {
f.logger.Fatal("Creating ES advanced visibility manager failed", tag.Error(err))
Expand All @@ -333,7 +332,7 @@ func (f *factoryImpl) NewVisibilityManager(
}
return p.NewVisibilityHybridManager(
visibilityMgrs,
resourceConfig.ReadVisibilityStoreName, //Didn't add new config for EnableReadVisibilityFromOS since we will use es-visibility and version: "os2" when migration is done
resourceConfig.ReadVisibilityStoreName,
resourceConfig.WriteVisibilityStoreName,
resourceConfig.EnableLogCustomerQueryParameter,
f.logger,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"github.com/pborman/uuid"
"github.com/stretchr/testify/require"

"github.com/uber/cadence/common"
"github.com/uber/cadence/common/config"
"github.com/uber/cadence/common/definition"
"github.com/uber/cadence/common/dynamicconfig"
Expand Down Expand Up @@ -74,7 +73,7 @@ func (s *DBVisibilityPersistenceSuite) SetupSuite() {
},
&service.Config{
ReadVisibilityStoreName: dynamicconfig.GetStringPropertyFnFilteredByDomain("db"),
WriteVisibilityStoreName: dynamicconfig.GetStringPropertyFn(common.AdvancedVisibilityModeOff),
WriteVisibilityStoreName: dynamicconfig.GetStringPropertyFn("db"),
EnableReadDBVisibilityFromClosedExecutionV2: dynamicconfig.GetBoolPropertyFn(false),
EnableDBVisibilitySampling: dynamicconfig.GetBoolPropertyFn(false),
},
Expand Down

0 comments on commit 9c7eba0

Please sign in to comment.